From b7aa07a45d14dd8f7f3867c70ce5f30c3b3d7b63 Mon Sep 17 00:00:00 2001 From: Jay Singh <140599484+mathdebate09@users.noreply.github.com> Date: Fri, 23 Aug 2024 17:27:22 +0530 Subject: [PATCH 1/4] Remove reference to the show Silicon Valley --- foundations/javascript_basics/clean_code.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/foundations/javascript_basics/clean_code.md b/foundations/javascript_basics/clean_code.md index 5576306d089..018a518a977 100644 --- a/foundations/javascript_basics/clean_code.md +++ b/foundations/javascript_basics/clean_code.md @@ -148,7 +148,7 @@ You might wonder why this variable is declared with all caps when we recommended ### Indentation and line length -Now it's time to head to more controversial topics. The war between coders that use tabs and coders that use spaces to indent their code is essentially a joke by now, as demonstrated in the [tabs versus spaces scene from the show Silicon Valley](https://www.youtube.com/watch?v=SsoOG6ZeyUI). +Now it's time to head to more controversial topics. The war between coders that use tabs and coders that use spaces to indent their code is essentially a joke by now. What actually matters is *consistency*. Choose a way to indent and stick to it. Various JavaScript style guides recommend different options, and one is not really superior to the other. We will look at style guides and related tools in more detail later in the curriculum. From ee27e916cc6b79b8f90676f5b7c36b2b3b48b9e0 Mon Sep 17 00:00:00 2001 From: Jay Singh <140599484+mathdebate09@users.noreply.github.com> Date: Fri, 23 Aug 2024 17:28:22 +0530 Subject: [PATCH 2/4] Add a reference to reddit thread on tabs vs space discussion --- foundations/javascript_basics/clean_code.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/foundations/javascript_basics/clean_code.md b/foundations/javascript_basics/clean_code.md index 018a518a977..25817889dd2 100644 --- a/foundations/javascript_basics/clean_code.md +++ b/foundations/javascript_basics/clean_code.md @@ -148,7 +148,7 @@ You might wonder why this variable is declared with all caps when we recommended ### Indentation and line length -Now it's time to head to more controversial topics. The war between coders that use tabs and coders that use spaces to indent their code is essentially a joke by now. +Now it's time to head to more controversial topics. The war between coders that use tabs and coders that use spaces to indent their code is essentially a [joke](https://www.reddit.com/r/programming/comments/p1j1c/tabs_vs_spaces_vs_both/) by now. What actually matters is *consistency*. Choose a way to indent and stick to it. Various JavaScript style guides recommend different options, and one is not really superior to the other. We will look at style guides and related tools in more detail later in the curriculum. From 6dfda6acabef14edfc936f3d0c98c75cb3392974 Mon Sep 17 00:00:00 2001 From: Jay <140599484+mathdebate09@users.noreply.github.com> Date: Sat, 24 Aug 2024 16:57:42 +0530 Subject: [PATCH 3/4] Rephrase the joke reference Co-authored-by: MaoShizhong <122839503+MaoShizhong@users.noreply.github.com> --- foundations/javascript_basics/clean_code.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/foundations/javascript_basics/clean_code.md b/foundations/javascript_basics/clean_code.md index 25817889dd2..4ab1792b7dc 100644 --- a/foundations/javascript_basics/clean_code.md +++ b/foundations/javascript_basics/clean_code.md @@ -148,7 +148,7 @@ You might wonder why this variable is declared with all caps when we recommended ### Indentation and line length -Now it's time to head to more controversial topics. The war between coders that use tabs and coders that use spaces to indent their code is essentially a [joke](https://www.reddit.com/r/programming/comments/p1j1c/tabs_vs_spaces_vs_both/) by now. +Now it's time to head to more controversial topics. There's already a joke about the [war between coders who indent with spaces versus tabs](https://www.reddit.com/r/programming/comments/p1j1c/tabs_vs_spaces_vs_both/). What actually matters is *consistency*. Choose a way to indent and stick to it. Various JavaScript style guides recommend different options, and one is not really superior to the other. We will look at style guides and related tools in more detail later in the curriculum. From 0b767b0b416dd753f0ab609b0f3375db72adc5d7 Mon Sep 17 00:00:00 2001 From: Jay <140599484+mathdebate09@users.noreply.github.com> Date: Sat, 24 Aug 2024 19:28:28 +0530 Subject: [PATCH 4/4] Rephrasing nits Co-authored-by: MaoShizhong <122839503+MaoShizhong@users.noreply.github.com> --- foundations/javascript_basics/clean_code.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/foundations/javascript_basics/clean_code.md b/foundations/javascript_basics/clean_code.md index 4ab1792b7dc..e686e2631d6 100644 --- a/foundations/javascript_basics/clean_code.md +++ b/foundations/javascript_basics/clean_code.md @@ -148,7 +148,7 @@ You might wonder why this variable is declared with all caps when we recommended ### Indentation and line length -Now it's time to head to more controversial topics. There's already a joke about the [war between coders who indent with spaces versus tabs](https://www.reddit.com/r/programming/comments/p1j1c/tabs_vs_spaces_vs_both/). +Now it's time to head to more "controversial" topics (there's a joke about the [war between coders who indent with spaces versus tabs](https://www.reddit.com/r/programming/comments/p1j1c/tabs_vs_spaces_vs_both/)). What actually matters is *consistency*. Choose a way to indent and stick to it. Various JavaScript style guides recommend different options, and one is not really superior to the other. We will look at style guides and related tools in more detail later in the curriculum.