Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTML Boilerplate lesson - Adjust the display sequence under Head element section #28686

Merged
merged 2 commits into from
Aug 22, 2024

Conversation

vamsijv
Copy link
Contributor

@vamsijv vamsijv commented Aug 22, 2024

Because

The Html Boilerplate lesson has this section Head element which is not inline with expected way of showing code snippet, thus leading to poor readability.

This PR

  • Addresses the reported issue by updating the sequence to the desired order: code snippet followed by the explanation of the relevant elements inside it. This allows for easy and better readability for the end users going through the lesson.
  • Modified the file in here with above mentioned changes: curriculum/foundations/html_css/html-foundations/html-boilerplate.md
  • Moved the code snippet in Head element and its related instructions to above the Meta and Title elements.

Issue

Closes #28601

Additional Information

None

Pull Request Requirements

  • I have thoroughly read and understand The Odin Project curriculum contributing guide
  • The title of this PR follows the location of change: brief description of change format, e.g. Intro to HTML and CSS lesson: Fix link text
  • The Because section summarizes the reason for this PR
  • The This PR section has a bullet point list describing the changes in this PR
  • If this PR addresses an open issue, it is linked in the Issue section
  • If any lesson files are included in this PR, they have been previewed with the Markdown preview tool to ensure it is formatted correctly
  • If any lesson files are included in this PR, they follow the Layout Style Guide

Copy link
Member

@KevinMulhern KevinMulhern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great stuff! thanks @vamsijv

@KevinMulhern KevinMulhern merged commit 547b3fd into TheOdinProject:main Aug 22, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content: Foundations Involves the Foundations content
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature Request : Making a change in the order between two parts of a lesson
2 participants