Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(build): isn't codecov a development-only dependency? #27

Closed
BrainCrumbz opened this issue Sep 15, 2016 · 4 comments · Fixed by #33
Closed

chore(build): isn't codecov a development-only dependency? #27

BrainCrumbz opened this issue Sep 15, 2016 · 4 comments · Fixed by #33

Comments

@BrainCrumbz
Copy link

Just installed loader in one of our team project, and noticed [email protected] as a sub-dependency. Just wondering if installed package can be slimmed down.
Thanks.

@hyp3rdino
Copy link

Size is just one issue: codecov as general dependency causes npm install to fail on NodeJS >=0.12.x. [email protected] apparently requires an incompatible and no longer maintained sub-dependency execSync.
├─ [email protected]
│ ├─ [email protected]

See:
execSync: Troubles with Node 0.12 #38

@tdsmithATabc
Copy link

Yeah execSync fails with a Native code compile failed! for my team. It also relies on [email protected] which throws up a number of compatibility warnings. (The current version is something like 4.1.8, which is what most of my other deps use.)

I know defeating npm dependency warnings is often an impossible goal, but this is the only one stopping me right now. 😛

@hyp3rdino
Copy link

I forked this project and moved codecov dependency to devDependencies which solves the Native code compile failed! issue for me. Anyhow, the issue looks only scary but the installation works fine regardless: effectively codecov is NOT used by any production code and npm install downloads all the really needed dependencies properly . This issue is primarily misleading and bloats the package.

@halfzebra
Copy link
Contributor

halfzebra commented Oct 12, 2016

I went ahead and created a PR #33

We have troubles with codecov as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants