Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The filter classes Before and After don't work #282

Closed
To-om opened this issue Apr 3, 2023 · 3 comments · Fixed by #310
Closed

The filter classes Before and After don't work #282

To-om opened this issue Apr 3, 2023 · 3 comments · Fixed by #310
Assignees
@Kamforka
Labels
2.x category:bug

Comments

@To-om
Copy link

To-om commented Apr 3, 2023

The filter class Before and After doesn't work: here. In the operator between, the fields _from and _to are both required.
Before and after can be implemented using _lt and _gt.
@To-om To-om added the 2.x label Apr 3, 2023
@Kamforka
Copy link
Collaborator

Kamforka commented Apr 3, 2023

Do we even need them in this case? Maybe we should just retire them in favour of the already existing Gt and Lt filters?

@Kamforka Kamforka self-assigned this Apr 3, 2023
@To-om
Copy link
Author

To-om commented Apr 3, 2023

I think we can remove them.

@To-om To-om changed the title The filter class Before and After doesn't work The filter classes Before and After don't work Apr 3, 2023
@Kamforka Kamforka linked a pull request Oct 9, 2023 that will close this issue
282 fix and update filters #310
Merged
Kamforka added a commit that referenced this issue Oct 9, 2023
@Kamforka
#282 - Fix and update filters
f1e3072
Kamforka added a commit that referenced this issue Oct 9, 2023
@Kamforka
#282 - Add filter tests
4bb8013
@Kamforka
Copy link
Collaborator

@To-om can you please check the fix in the corresponding #310 ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Kamforka Kamforka

Labels
2.x category:bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

282 fix and update filters TheHive-Project/TheHive4py
2 participants
@Kamforka @To-om