Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to customize Navbar toggle button icon #936

Closed
shafinmahmud opened this issue Apr 22, 2018 · 3 comments
Closed

Add option to customize Navbar toggle button icon #936

shafinmahmud opened this issue Apr 22, 2018 · 3 comments
Assignees
Labels
Milestone

Comments

@shafinmahmud
Copy link

shafinmahmud commented Apr 22, 2018

I was looking for a way to customize the navbar toggle button icon. By default, the navBar tag generates the following code

<button type="button" class="navbar-toggle" data-toggle="collapse" 
        data-target="#nav-header_inner">

       <span class="sr-only">Toggle navigation</span>
       <span class="icon-bar"></span>
       <span class="icon-bar"></span>
       <span class="icon-bar"></span>
</button>

I want to have some option that is to replace those icon-bar spans with some icons or anything. Like for my case, I am looking for generated code be like

<button type="button" class="navbar-toggle" data-toggle="collapse" 
        data-target="#nav-header_inner">

        <span class="glyphicon glyphicon-menu-hamburger"></span>
</button>
@shafinmahmud shafinmahmud changed the title Option to customize Navbar toggle button icon Add option to customize Navbar toggle button icon May 7, 2018
@stephanrauh
Copy link
Collaborator

I've added the feature for BootsFaces 1.2.1:

      <b:navBar brand="Brand" brandHref="#" fluid="true">
      	<f:facet name="kebab">
      		<span class="fa fa-chevron-right"></span>
      	</f:facet>
        <b:navbarLinks>
          <b:navLink value="Link" href="#"></b:navLink>
          <b:navLink value="Link" href="#"></b:navLink>
        </b:navbarLinks>
      </b:navBar>

@stephanrauh stephanrauh self-assigned this Jun 1, 2018
@stephanrauh stephanrauh added this to the v1.5.0 milestone Jun 1, 2018
stephanrauh added a commit to TheCoder4eu/BootsFacesWeb that referenced this issue Jun 1, 2018
@stephanrauh
Copy link
Collaborator

I've uploaded a developer snapshot to Maven Central. #369 describes how to get it.

@shafinmahmud
Copy link
Author

Thanks for your update. Hope we will find this helpful.

@stephanrauh stephanrauh modified the milestones: v1.5.0, v1.3.0 Oct 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants