Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search highlighting with mark.js for DataTable #924

Closed
chsreedhar opened this issue Mar 20, 2018 · 6 comments
Closed

Search highlighting with mark.js for DataTable #924

chsreedhar opened this issue Mar 20, 2018 · 6 comments
Assignees
Milestone

Comments

@chsreedhar
Copy link

Search highlighting sounds interesting.
This behaviour allows users to find what they're searching for more faster and therefore leads to a better usability.

This feature can be added as default when searching attribute set to true for b:dataTable,

@stephanrauh
Copy link
Collaborator

Quick check: License is MIT, added file size is only a few KB. Let's examine it closer!

@chsreedhar Currently we're developing BootsFaces 2, which is a complete re-write of BootsFaces based on Bootstrap 4. Do you happen to know whether datatables.net is compatible to Bootstrap 4, or if there's a better alternative?

@chsreedhar
Copy link
Author

DataTables can be integrated seamlessly with Bootstrap 4
Example

@stephanrauh
Copy link
Collaborator

Thanks! I didn't expect it to be so easy!

stephanrauh added a commit to TheCoder4eu/BootsFacesWeb that referenced this issue Apr 15, 2018
@stephanrauh stephanrauh self-assigned this Apr 15, 2018
@stephanrauh stephanrauh added this to the v1.5.0 milestone Apr 15, 2018
@stephanrauh
Copy link
Collaborator

stephanrauh commented Apr 15, 2018

I've uploaded a new developer snapshot of BootsFaces to Maven Central. See #369 how to get it. The implementation of the feature is finished. For some reason, the demo has a still a little bug (the datatable only accepts constant values of mark-search-results, but fails with EL expressions).

@stephanrauh
Copy link
Collaborator

Note that Bootstrap redefines the CSS class .mark. If you prefer the original colors instead of yellow, you need to add a CSS code snippet.

@chsreedhar
Copy link
Author

Thanks for immediate implementation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants