Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Weird issue with no styling on DataTable #247

Closed
XaeroDegreaz opened this issue Jan 14, 2016 · 4 comments
Closed

Weird issue with no styling on DataTable #247

XaeroDegreaz opened this issue Jan 14, 2016 · 4 comments
Assignees
Labels
Milestone

Comments

@XaeroDegreaz
Copy link
Contributor

All of the Bootstrap styling works everywhere else within my application, but no matter where I place the DataTable using Bootsfaces 0.8.0, it just has no styling o_O

I was shocked to see the awesome improvements to the DataTable, so I looked on the Bootsfaces site to see what was new. I noticed there is Bootsrap styling on all of the components of the table in your example but when I use the table, it looks unstyled:

<b:panel>
    <f:facet name="heading">
        <b><h:outputText />Agents to be Reviewed</b>
    </f:facet>
    <b:dataTable
        styleClass="table table-striped table-bordered"
        value="#{indexPage.agentsToBeReviewed}"
        var="annotations">
        <h:column>
            <f:facet name="header">Team</f:facet>
            #{annotations.team.name}
        </h:column>
    </b:dataTable>
</b:panel>

image

Is there some other dependency I need to add?

@stephanrauh
Copy link
Collaborator

I'm glad you like our datatable! It's an unfinished prototype, so bear with us. I know it's far from being perfect.

As for your question: at first glance, your screenshot looks OK to me. The only thing that's odd is the paginator at the bottom. What do you refer to when you say there's no styling?

@XaeroDegreaz
Copy link
Contributor Author

The drop down menu, and the filter input are not styled with bootstrap.
Neither are the previous, 1, 2, .... 5, next buttons.

If you compare my screenshot to the datatable shown on the Bootsfaces
website demo, you can clearly see that mine is missing all of the Bootstrap
styling for some reason.

I understand that the new datatable is unfinished, but I wanted to make
sure that it wasn't something I was overlooking.

Everything else on Bootsfaces works wonderfully, and I can tough it out;
the functionality of the page drop down and the filter is freaking sweet so
I'll gladly wait for the fix on the actual styling.
On 14 Jan 2016 13:50, "Stephan Rauh" [email protected] wrote:

I'm glad you like our datatable! It's an unfinished prototype, so bear
with us. I know it's far from being perfect.

As for your question: at first glance, your screenshot looks OK to me. The
only thing that's odd is the paginator at the bottom. What do you refer to
when you say there's no styling?


Reply to this email directly or view it on GitHub
#247 (comment)
.

@stephanrauh
Copy link
Collaborator

Now that you say I... I looked at it all the time without recognizing there was something missing which already worked before. I simply forgot to add the JavaScript code. I've uploaded a new developer snapshot of BootsFaces to Maven Central. See #151 on how to get it.

As a quick workaround, simply add this code snippet to your XHTML file:

<h:outputScript library="bsf" name="js/jquery.dataTables.min.js" />
<h:outputScript library="bsf" name="js/dataTables.bootstrap.min.js" />

I added it to the body - maybe it works in the header to, but I didn't try.

@stephanrauh stephanrauh added this to the v0.8.1 milestone Jan 15, 2016
@stephanrauh stephanrauh self-assigned this Jan 15, 2016
@XaeroDegreaz
Copy link
Contributor Author

Thanks, adding it in the body works properly :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants