Newest source fails build in my environment

[korsgaard]

Worked fine last week... (and still does with my fork...)

Plugins/cordova-plugin-nativestorage/NativeStorage.m:45:8: warning: incompatible pointer to integer conversion initializing 'BOOL' (aka 'signed char') with an expression of type 'id' [-Wint-conversion]
                BOOL aBoolean = [command.arguments objectAtIndex:1];
                     ^          ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Plugins/cordova-plugin-nativestorage/NativeStorage.m:214:32: error: expected expression
                if(reference!=nil && (NsNull*) aString == [NsNull null]) {
                                             ^
Plugins/cordova-plugin-nativestorage/NativeStorage.m:214:25: error: use of undeclared identifier 'NsNull'
                if(reference!=nil && (NsNull*) aString == [NsNull null]) {
                                      ^
Plugins/cordova-plugin-nativestorage/NativeStorage.m:223:3: error: expected expression
                else
                ^
Plugins/cordova-plugin-nativestorage/NativeStorage.m:228:3: error: expected expression
        }];
         ^
Plugins/cordova-plugin-nativestorage/NativeStorage.m:266:5: error: expected ']'
@end
    ^
Plugins/cordova-plugin-nativestorage/NativeStorage.m:266:5: error: expected '}'
Plugins/cordova-plugin-nativestorage/NativeStorage.m:208:1: note: to match this '{'
{

[korsgaard]

Seem to have to go back to 2.2.1 to have a successful build... otherwise the build fails or the ap starts with a white screen...

[alokrajiv]

cc @GillesC

[alokrajiv]

@mbkinnovo are you building from GitHub master? because we haven't updated NPM for sometime now.

[korsgaard]

Yeah, did build from the newest github.

[alokrajiv]

@GillesC our master is then unstable...
In the meantime, @mbkinnovo you should try building from npm then.

[alokrajiv]

Hi, is anyone else facing issue? Looks to me the master is actually stable..no other reported errors.

[ealch]

Still not working, I think that you messed up in this commit.
Since you mistyped 'NsNull' and you opened two times the clauses.

[korsgaard]

Thank you @ealch - I've created pull request #109 fixing this...!

[GillesC]

Merged your PR (aff0b51) thank you for your contribution! I will close this issue now :)

[alokrajiv]

Sorry about the mess up :(

thanks, @ealch & @mbkinnovo 👍 👍 👍 ... dunno how it was missed.

.... I really need to automate those tests onto Travis #126

.... will squeeze in sometime in the coming weeks and get it up...so this never happens again