Combo calculator allows combos that contain feature dependencies.

[nihohit]

[dependencies]
foo = []
bar = ["foo"]
foobar = ["bar"]

The combos ["foobar", "bar"], ["foobar", "foo"] & ["bar", "foo"] should be omitted, since they're implied by the dependency graph. They should be automatically treated as

[[rule]]
when = "foobar"
require = ["foo", "bar"]
[[rule]]
when = "foo"
require = ["bar"]

[BD103]

I agree. Feature dependencies are currently ignored, but it's leading to edge cases like these. Thanks for the report!

[nihohit]

I'm willing to try and contribute a fix, just wanted to make sure - are you allocation-shy, or is it ok to build a dependency tree with lots of cloned strings?

…

On Wed, 2 Oct 2024, 17:31 BD103, ***@***.***> wrote: I agree. Feature dependencies are currently ignored, but it's leading to edge cases like these. Thanks for the report! — Reply to this email directly, view it on GitHub <#19 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABDEBBWGH24737TXQDZYLV3ZZP7U5AVCNFSM6AAAAABPGQCWD6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGOBYHAYDGNRSGM> . You are receiving this because you authored the thread.Message ID: ***@***.***>

[BD103]

All feature names are interned in this module. If you need help with the code, I'm @BD103 on Bevy's Discord! :)