Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Add flatpages and ckeditor for a light cms experience #492

Closed
wants to merge 1 commit into from

Conversation

samihibrahim
Copy link
Contributor

@samihibrahim samihibrahim force-pushed the samih/help_centre_admin branch from 4817f63 to e640e2d Compare September 18, 2021 20:59
@@ -1,3 +1,15 @@
# from django.contrib import admin
from django.contrib import admin
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this a good place for this or should I have used another admin.py file? 🤔

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good question, we're using the public app as a source of things that should be accessible to the public without logging into the website so FlatPages-related stuff seems like it should fit well here (the "admin" stuff is never accessible to the public anyways)

Copy link
Member

@ryanwilsonperkin ryanwilsonperkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work :) Let me know if there's any help I can offer with this issue

@@ -1,3 +1,15 @@
# from django.contrib import admin
from django.contrib import admin
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good question, we're using the public app as a source of things that should be accessible to the public without logging into the website so FlatPages-related stuff seems like it should fit well here (the "admin" stuff is never accessible to the public anyways)

@@ -0,0 +1,9 @@
{% extends 'base.html' %}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can also tweak the base.html template if you need to include other sections from flatpages (not sure if there's more needed beyond the title/content)

@ryanwilsonperkin
Copy link
Member

Closing as stale, please let me know if you're still interested in taking on this work

@ryanwilsonperkin ryanwilsonperkin deleted the samih/help_centre_admin branch April 19, 2022 22:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Help centre with articles that can be written in the admin
2 participants