-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Add flatpages and ckeditor for a light cms experience #492
Conversation
samihibrahim
commented
Sep 18, 2021
- Closes Help centre with articles that can be written in the admin #440.
- Still looking into ways of making the editing experience easier (e.g. add defaults, remove extra fields, ...)
4817f63
to
e640e2d
Compare
@@ -1,3 +1,15 @@ | |||
# from django.contrib import admin | |||
from django.contrib import admin |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this a good place for this or should I have used another admin.py
file? 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good question, we're using the public
app as a source of things that should be accessible to the public without logging into the website so FlatPages-related stuff seems like it should fit well here (the "admin" stuff is never accessible to the public anyways)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work :) Let me know if there's any help I can offer with this issue
@@ -1,3 +1,15 @@ | |||
# from django.contrib import admin | |||
from django.contrib import admin |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good question, we're using the public
app as a source of things that should be accessible to the public without logging into the website so FlatPages-related stuff seems like it should fit well here (the "admin" stuff is never accessible to the public anyways)
@@ -0,0 +1,9 @@ | |||
{% extends 'base.html' %} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can also tweak the base.html
template if you need to include other sections from flatpages (not sure if there's more needed beyond the title/content)
Closing as stale, please let me know if you're still interested in taking on this work |