Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FR] Implement Controls for [PLAYSTATION Eye (PS3)] #7

Closed
Rufus242 opened this issue Apr 20, 2021 · 3 comments
Closed

[FR] Implement Controls for [PLAYSTATION Eye (PS3)] #7

Rufus242 opened this issue Apr 20, 2021 · 3 comments
Assignees
Labels
done enhancement New feature or request

Comments

@Rufus242
Copy link

Camera manufacturer and model (ie. NexiGO N660):
PLAYSTATION Eye (for PLAYSTATION 3)

Unknown controls information (click 'Copy to Clipboard' on the warning and paste here):
{
"white_balance_automatic": {
"type": "bool",
"default": "1",
"value": "1"
},
"exposure": {
"type": "int",
"min": "0",
"max": "255",
"step": "1",
"default": "120",
"value": "127"
},
"gain_automatic": {
"type": "bool",
"default": "1",
"value": "1",
"flags": "update"
}
}

@Rufus242 Rufus242 added the enhancement New feature or request label Apr 20, 2021
@The-EG The-EG self-assigned this Apr 20, 2021
@The-EG
Copy link
Owner

The-EG commented Apr 20, 2021

Hey there, I've added 'White Balance Automatic', 'Exposure' and 'Gain Automatic' to the controls on the RC branch.

You can try this out now by reinstalling (no uninstall necessary) from this URL: https://github.com/The-EG/OctoPrint-CameraSettings/archive/refs/heads/rc.zip

@The-EG The-EG added the done label Apr 20, 2021
@Rufus242
Copy link
Author

Hi,
the settings are working properly :)
But it seems that these new settings are not saved in the Preset profiles?

@The-EG
Copy link
Owner

The-EG commented Apr 23, 2021

Ok, thank you for checking.

The settings should automatically be included when saving a new preset, but any preset saved previously wouldn't have them. And, while thinking about explaining this, you may have found a nuance with how presets are saved and loaded:

It is possible that the new settings aren't saved in a preset in a very specific situation:

  • Old preset exists before the settings were added
  • You updated to the version with the added settings
  • Deleted the old preset and saved a new one with the same name
  • Did not click save, but tried to load the 'new' preset

If that's the case, that is because presets are not actually 'saved' until the save button on the settings window is pressed. That could be confusing, so I'll have to look into a way to work around that.

I've created a new issue for this and I'll see if I can make the behavior less confusing: #9

@The-EG The-EG closed this as completed Apr 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
done enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants