-
-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Restore Deprecated Items #1447
Comments
Did some research into this subject. Here are my findings: DEPRECATED NPC DROPS
DEPRECATED QUEST REWARDS
DEPRECATED SET ITEMS
MISC FINDINGDS
|
Good research work, we could use these findings to restore them. Do you have any links that helped you find this ? By using the logic of display_id number again, we could also assume that all deprecated items with a very high display_id (near the max_item_display_id for 0.5.3) are also most likely in use. I'm not sure from which point we could consider this reliable, but it could eventually apply to all deprecated items with a display_id higher than 11k. Deprecated items, display_id 11000 to 11802 :
|
I don't have a whole lot of time as of this post, but it's interesting that you brought up the Runes of Summoning. This item is actually in-use on release, as apart of the undead warlock quest to learn the Summon Voidwalker spell titled "The Binding" (1471). Turns out, not only do the other quest items that are apart of this chain exist in-game in the 0.5.3 database according to what we know was the last item, but all of the quests in this chain are in the 1471-1478 ID range, which is too high for quests in 0.5.3. Not only that, but this same rule applies for the Summon Imp quest for undead warlocks called "Piercing the Veil" (1470) with its quest items called "Rattlecage Skull" (6281), as well as the Succubus questline with the hearts (Dalin's Heart and Comar's Heart, IDs 6312 and 6313 respectively). We even have the spells in the 0.5.3 database that summon the enemy voidwalker/succubus at the summoning circles, which provide a "Requires Summoning Circle" error message when you try to use them in-game (https://db.thealphaproject.eu/index.php?action=show_spell&id=7728&filter=summon+voidwalker&sort_order=Name_enUS&pos=3&max=3, https://db.thealphaproject.eu/index.php?action=show_spell&id=7729&filter=summon+succubus&sort_order=Name_enUS&pos=3&max=3). Also, the projections of Dalin and Comar which briefly spawn during a cutscene in said succubus questline exist in 0.5.3 with their proper displayIDs (https://db.thealphaproject.eu/index.php?action=show_creature&id=5691&sort_order=entry&page=25&pos=42&max=4909, https://db.thealphaproject.eu/index.php?action=show_creature&id=5692&sort_order=entry&page=25&pos=43&max=4909). With all of this evidence, it seems like what we believed to be the last quest in 0.5.3 (1339) is actually wrong, and the final quest was much higher. I can't say if these quests were available to players, but given this evidence it's very believable that these quests were at least late into development during 0.5.3 (which would mean they would exist in the database but with the tag and no way to start them,) and because of their high IDs, every quest underneath them was either also in development or was available to players (should be handled in a case-by-case basis.) This would fix issues like the missing quest in The Missing Diplomat, making it completable. TLDR: The last quest in 0.5.3 may not be 1339. Until we find a definitive last quest, every quest that is at or below ID 1478 should be reimplemented. |
Regarding warlock quests, some other game data also suggest that the quests could've existed. QuestSort.dbc has as final ID the 'Warlock' type quest.
SpellFocusObject.dbc has as final ID |
I don't know how the max quest was determined, but 1339 seems consistent. The quests following involve items or NPC higher than max entries There are several gaps between the last quest entry, in some cases when blizz update a quest, they delete the old one and create a new entry This could perhaps be related to the warlock quests and explain why items are ingame but the reworked quests are not see gaps between 1324-1338 and 1339-1358
|
With Wayback Machine down, it's difficult for me to find evidence right now of what quests may have been in these quest gaps. Considering the Warlock quest evidence, they are possibly in these gaps alongside other quests like the Flayed Demon Hide questline and the missing quest in The Missing Diplomat. We may have to "adlib" a bit, though, in terms of the IDs. |
Using the same logic, we can assume that all deprecated items with a spell_id higher than the max for 0.5.3 should also be used for 0.5.3 Deprecated Item with spellID higher than 0.5.3
|
The disenchant id is a custom column, its not something sent by the server, this shouldn't be used as indication for anything. |
I've updated it, thanks for the info. |
Can confirm that Runes of Summoning existed since we have the Summoning Circle-activated Summon Voidwalker spell ID in 0.5.3. Unholy Avenger has a very low ID so it was likely a GM test item, we can also see players with this sword in very old trailers. |
So after some research, it seems like players have access to head items with stats at level 20+, with a minimum item level of 30. This is when excluding engineering, of course. This means that all items that have an item level below 30 and/or a level requirement below 20 don't need stats added to them as part of restoration. An example of this would be Captain Sander's Eyepatch, all we'd have to do is change the quality to white, add a level requirement of 10 or 5, give it an existing and proper displayID, and we could reasonably re-add it as-is. However, some items like Band of the Order that do have an item level below 30 may have had a higher item level before being deprecated (in this case, Band of the Order is a sister item [entry ID right next to] to Circlet of the Order, which has an item level of 38, implying that the Band of the Order may have had a higher ilvl.) We'd have to go through each item individually and determine if it has a sister item, is part of a set, and if it does compare the item levels and make the necessary changes. |
There's a few items that I left out of my second Deprecated Item Restoration pull request due to the belief that they may have had stats, similar to Whisperwind Headdress, before their deprecation. The items I flagged as possibly having stats, and thereby left out, are as follows:
I'd also like to make mention of Militia Handaxe, which was a reward from Brotherhood of Thieves and an item that I did include. Because our only source of this item's damage values comes from 1.12, it has abnormally low damage values compared to the other Militia weapons. Because of this, this weapon and the others like Orcslayer may need rescaling. |
Restore Deprecated Items
If an item's display was updated after 0.5.3 then the item is in use for 0.5.3
Items that were already deprecated by version 0.5.3 wouldn't typically receive updates, this means that if an item is marked as deprecated but has a display_id higher than the max_display_id for version 0.5.3, it should be considered in use for version 0.5.3.
An item is considered deprecated if it does not appear in any tables such as quests, loot, crafting, vendors, etc.
This list will evolve as we resolve display_id issues attached to unused items, which is why it must be preserved to restore them.
List of deprecated items concerned
SQL Query
The text was updated successfully, but these errors were encountered: