Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Bug ➾ The Micheline editor does not render for entrypoint balance_of in NFT scaffold #1605

Open
2 of 6 tasks
ac10n opened this issue Dec 9, 2022 · 6 comments
Open
2 of 6 tasks
Assignees
Labels
bug Something isn't working

Comments

@ac10n
Copy link
Contributor

ac10n commented Dec 9, 2022

🚥 Status (Internal Taqueria Team Use Only)

  • 🔬 Investigated and Verified
  • ⚗️ Solution Identified and Designed
  • 🧫 Dev Implementation of Fix
  • 🧪 Fix Tested and Validated
  • 🏆 PR Merged

🆘 What happened?

The Micheline editor in the VsCode Extension does not render for the entrypoing balance_of in NFT scaffold.

🆘 Steps to Reproduce?

  1. Scaffold the NFT scaffold
  2. Install the newest Flextesa plugin
  3. Start the sandbox
  4. Deploy main.tz to the sandbox
  5. Open Sandboxes > local > contracts > KT1.... > entrypoints > balance_of
  6. Click the 📞 icon: "invoke entrypoint"
  7. The editor tab that appears should have a michelin editor but is empty

🪵 Relevant log output

No response

🐘 How impactful is this bug?

🤔 Notable but managable

⏱️ Prevalance

No response

💻 Operating System

Linux

🕸️ System Architecture

x64

🌮 Taqueria Version

No response

🌿 Node.js Version

No response

☎️ Contact Details

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct
@ac10n ac10n added bug Something isn't working triage Requires triage labels Dec 9, 2022
@alexzbusko alexzbusko moved this to 📫 Inbox in 📬 Inbox and Triage Dec 9, 2022
@michaelkernaghan
Copy link
Contributor

michaelkernaghan commented Dec 9, 2022 via email

@ac10n
Copy link
Contributor Author

ac10n commented Dec 9, 2022

why is this assigned to me?

On Fri, Dec 9, 2022 at 12:45 AM AlirezaHaghshenas @.> wrote: Assigned #1605 <#1605> to @michaelkernaghan https://github.com/michaelkernaghan. — Reply to this email directly, view it on GitHub <#1605 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/ASWO3VSKLOJ5PPNGDI6WTS3WMLWTDANCNFSM6AAAAAASZCZEYA . You are receiving this because you were assigned.Message ID: @.>

Probably bugs get automatically assigned to you now.

@michaelkernaghan
Copy link
Contributor

michaelkernaghan commented Dec 12, 2022 via email

@hu3man hu3man changed the title 🐛 Bug ➾ The micheling editor does not render for entrypoing balance_of in NFT scaffold 🐛 Bug ➾ The Micheline editor does not render for entrypoint balance_of in NFT scaffold Dec 15, 2022
@hu3man hu3man removed the triage Requires triage label Dec 15, 2022
@michaelkernaghan michaelkernaghan removed their assignment Jan 8, 2023
@ac10n
Copy link
Contributor Author

ac10n commented Jan 18, 2023

Entrypoint's parameter type containes a contract 'params.
These are not implemented.

Also, in many cases, the Micheline editor does not load randomly. If we close the editor (not the whole IDE) and re-open the Micheline editor, that can be fixed.

@ac10n
Copy link
Contributor Author

ac10n commented Jan 18, 2023

This will also fail if an entrypoint's datatype has or in it, meaning there are multiple ways to invoke it (similar to how one contract's argument datatype enables multiple entrypoints). Example: NFT scaffold's update_operators

@hu3man
Copy link
Contributor

hu3man commented Jan 19, 2023

Thanks for the update @AlirezaHaghshenas. Will defer this till after the milestone

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants