Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: 上云环境针对0区域限制新增主机校验提到API层级 (closed #2501) #2508

Open
wants to merge 1 commit into
base: v2.4.8-dev
Choose a base branch
from

Conversation

jpyoung3
Copy link
Collaborator

@jpyoung3 jpyoung3 commented Dec 5, 2024

Reviewed, transaction id: 25959

PR

CheckList(PR Assigners)

确认已完成以下操作:

  • 已将分支与当前合入分支同步
  • 已在关联 Issue 中补充「功能自测」部分内容
  • 已更新关联 Issue 的状态 backlog -> todo -> for test -> tested(需通过测试同学测试) -> done
  • 将 PR 添加上 pr/reviewable

CheckList(PR Reviewers)

确认已完成以下操作:

  • 检查关联 Issue 「功能自测」部分内容
  • 必要时打回 pr/reviewable,要求重新修改
  • 及时 Approve

@jpyoung3 jpyoung3 requested a review from wyyalt December 5, 2024 09:06
@jpyoung3 jpyoung3 added the pr/reviewable 可被 review 的 PR label Dec 5, 2024
@jpyoung3
Copy link
Collaborator Author

jpyoung3 commented Dec 5, 2024

企业微信截图_17333897147071

@codecov-commenter
Copy link

codecov-commenter commented Dec 5, 2024

Codecov Report

Attention: Patch coverage is 52.80899% with 42 lines in your changes missing coverage. Please review.

Please upload report for BASE (v2.4.8-dev@847a5d7). Learn more about missing BASE report.

Files with missing lines Patch % Lines
apps/node_man/tools/job.py 50.00% 41 Missing ⚠️
...nents/collections/agent_new/add_or_update_hosts.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##             v2.4.8-dev    #2508   +/-   ##
=============================================
  Coverage              ?   74.59%           
=============================================
  Files                 ?      406           
  Lines                 ?    29424           
  Branches              ?        0           
=============================================
  Hits                  ?    21948           
  Misses                ?     7476           
  Partials              ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jpyoung3 jpyoung3 force-pushed the _V2.4.X/dev_issue#2501 branch 2 times, most recently from 7baadcb to f5f4160 Compare December 9, 2024 03:11
@jpyoung3 jpyoung3 force-pushed the _V2.4.X/dev_issue#2501 branch from c607be1 to 3b706e7 Compare December 9, 2024 03:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr/reviewable 可被 review 的 PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants