Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Add node event hook #214 #217

Closed

Conversation

benero
Copy link
Contributor

@benero benero commented Jan 3, 2024

No description provided.

@benero benero closed this Jan 3, 2024
@benero benero reopened this Jan 3, 2024
Copy link

codecov bot commented Jan 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (427211c) 89.22% compared to head (3d18085) 89.28%.
Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #217      +/-   ##
===========================================
+ Coverage    89.22%   89.28%   +0.05%     
===========================================
  Files           61       61              
  Lines         3491     3509      +18     
===========================================
+ Hits          3115     3133      +18     
  Misses         376      376              
Files Coverage Δ
bamboo_engine/engine.py 96.39% <ø> (ø)
bamboo_engine/eri/interfaces.py 99.57% <100.00%> (+<0.01%) ⬆️
bamboo_engine/eri/models/event.py 100.00% <100.00%> (ø)
bamboo_engine/handlers/service_activity.py 97.53% <100.00%> (+0.12%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b40a935...3d18085. Read the comment docs.

@@ -598,6 +598,15 @@ class TaskMixin:
引擎任务派发相关接口
"""

def pre_execute(self, root_pipeline_id: str, node_id: str):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

需要更新下 api version

@benero benero closed this Jan 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants