Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework FakeSignalManager tests to fix flakiness #200

Open
Jeehut opened this issue Nov 5, 2024 · 0 comments
Open

Rework FakeSignalManager tests to fix flakiness #200

Jeehut opened this issue Nov 5, 2024 · 0 comments
Assignees

Comments

@Jeehut
Copy link
Contributor

Jeehut commented Nov 5, 2024

During the migration to Swift testing, I noticed that the tests for the FakeSignalManager have become flaky. Each time I run tests, other tests pass and others fail. Sometimes all pass. But this is not a situation we can keep as is. Because no logic was changed (neither in the tests nor in the related code) and the tests sometimes all pass, I'm assuming that there is no actual problem with the library and decided to disable them for now. The problem most probably lies in the way the SDK uses different dispatch queues in different places and Swift 6's concurrency logic not playing well with that in Swift Testing.

So, I think we need to rework how the whole Signal manager testing logic is implemented.

@Jeehut Jeehut self-assigned this Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant