Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Damn8.0 #17

Open
amanalar opened this issue Jul 17, 2018 · 6 comments
Open

Damn8.0 #17

amanalar opened this issue Jul 17, 2018 · 6 comments

Comments

@amanalar
Copy link

hallo again

9x tekticles\tekticles-Alpha.lua:90: 'for' limit must be a number
tekticles\tekticles-Alpha.lua:90: in function <tekticles\tekticles.lua:13>

Locals:
NORMAL = "tekticles\Calibri.ttf"
BOLD = "tekticles\CalibriBold.ttf"
BOLDITALIC = "tekticles\CalibriBoldItalic.ttf"
ITALIC = "tekticles\CalibriItalic.ttf"
NUMBER = "tekticles\CalibriBold.ttf"
(for index) = 1
(for limit) = nil
(for step) = 1
(*temporary) = 7
(*temporary) = ChatFrame7 {
GatherSelectedText = defined =[C]:-1
RefreshIfNecessary = defined =[C]:-1
OnPostShow = defined =[C]:-1
isDisplayDirty = true
onScrollChangedCallback = defined =[C]:-1
GetNumVisibleLines = defined =[C]:-1
ScrollUp = defined =[C]:-1
SetTimeVisible = defined =[C]:-1
0 =
tellTimer = 6094.9
UpdateSelectingText = defined =[C]:-1
fadeDurationSecs = 3
SetTextCopyable = defined =[C]:-1
CalculateLineAlphaValueFromTimestamp = defined =[C]:-1
GetFading = defined =[C]:-1
IsTextCopyable = defined =[C]:-1
Clear = defined =[C]:-1
shouldFadeAfterInactivity = true
channelList =

{
}
GetTimeVisible = defined =[C]:-1
GetJustifyV = defined =[C]:-1
ScrollToBottom = defined =[C]:-1
GetInsertMode = defined =[C]:-1
GetMaxLines = defined =[C]:-1
Show = defined @FrameXML\FrameLocks.lua:131
BackFillMessage = defined =[C]:-1
originalHide = defined =[C]:-1
UnpackageEntry = defined =[C]:-1
ScrollBar = {
}
hasOwnFontObject = true
GetIndentedWordWrap = defined =[C]:-1
messageTypeList =
{
}
originalShow = defined =[C]:-1
GetFont = defined =[C]:-1
OnFontObjectUpdated = defined =[C]:-1
SetMaxLines = defined =[C]:-1
timeVisibleSecs = 120
OnPostUpdate = defined =[C]:-1
buttonSide = "left"
RefreshDisplay = defined =[C]:-1
SetFontObject = defined =[C]:-1
SetIndentedWordWrap = defined =[C]:-1
textIsCopyable = false
MarkLayoutDirty = defined =[C]:-1
SetOnScrollChangedCallback = defined =[C]:-1
ResizeButton = ChatFrame7ResizeButton {
}
SetFont = defined =[C]:-1
fontObject = table: 0000027503436AC0 {
}
overrideFadeTimestamp = 0
alternativeDefaultLanguage = "Orcish"
SetInsertMode = defined =[C]:-1
MarkDisplayDirty = defined =[C]:-1
FontStringContainer = {
}
defaultLanguage = "Orcish"
SetShadowOffset = defined =[C]:-1
GetMessageInfo = defined =[C]:-1
GetOnScrollChangedCallback = defined =[C]:-1
Background = ChatFrame7Background {
}
ScrollDown = defined =[C]:-1
AtTop = defined =[C]:-1
GetFontObject = defined =[C]:-1
zoneChannelList =
{
}
SetScrollOffset = defined =[C]:-1
CalculateSelectingCharacterIndicesForVisibleLine = defined =[C]:-1
PackageEntry = defined =[C]:-1
isLayoutDirty = true
MakeFontObjectCustom = defined =[C]:-1
CanEffectivelyFade = defined =[C]:-1
onDisplayRefreshedCallback = defined =[C]:-1
CalculateNumVisibleLines = defined =[C]:-1
insertMode = 2
visibleLines =
{
}
OnPreSizeChanged = defined =[C]:-1
scrollOffset = 0
GetScrollOffset = defined =[C]:-1
ResetSelectingText = defined =[C]:-1
historyBuffer =
{
}
editBox = ChatFrame7EditBox {
}
ScrollToBottomButton = {
}
Hide = defined @FrameXML\FrameLocks.lua:127
GetTextColor = defined =[C]:-1
GetPagingScrollAmount = defined =[C]:-1
CallOnDisplayRefreshed = defined =[C]:-1
SetJustifyV = defined =[C]:-1
AddMessage = defined @Ora3\modules\ReadyCheck.lua:791
GetSpacing = defined =[C]:-1
OnPreLoad = defined =[C]:-1
GetScaledCursorPosition = defined =[C]:-1
OnPostMouseUp = <fu

@Daeveren
Copy link

:(

Message: Interface\AddOns\tekticles\tekticles.lua:89: 'for' limit must be a number
Time: Wed Jul 18 13:13:47 2018
Count: 1
Stack: Interface\AddOns\tekticles\tekticles.lua:89: 'for' limit must be a number
...ce\AddOns\TradeSkillMaster\Core\Lib\ErrorHandler.lua:699: in function <...ce\AddOns\TradeSkillMaster\Core\Lib\ErrorHandler.lua:656>
[C]: ?
Interface\AddOns\tekticles\tekticles.lua:89: in function <Interface\AddOns\tekticles\tekticles.lua:13>
[C]: ?
[C]: in function LoadAddOn' ...e\AddOns\TradeSkillMaster\Core\UI\AuctionUI\Core.lua:33: in function pendingCallback'
Interface\AddOns\TradeSkillMaster\Core\Lib\Delay.lua:160: in function <Interface\AddOns\TradeSkillMaster\Core\Lib\Delay.lua:127>

Locals: errMsg = "Interface\AddOns\tekticles\tekticles.lua:89: 'for' limit must be a number"
errorTime = 91140351.120974
tsmErrMsg = nil
notOld = false
oldModule = nil
private =

{
AddonBlockedEvent = defined @interface\AddOns\TradeSkillMaster\Core\Lib\ErrorHandler.lua:369
num = 0
ErrorHandler = defined @interface\AddOns\TradeSkillMaster\Core\Lib\ErrorHandler.lua:104
errorFrame = {
}
origErrorHandler = defined @interface\SharedXML\SharedBasicControls.lua:295
errorReports =
{
}
SubmitErrorReport = defined @interface\AddOns\TradeSkillMaster\Core\Lib\ErrorHandler.lua:384
SantizeErrorReportString = defined @interface\AddOns\TradeSkillMaster\Core\Lib\ErrorHandler.lua:377
IsTSMAddon = defined @interface\AddOns\TradeSkillMaster\Core\Lib\ErrorHandler.lua:349
}
MAX_STACK_DEPTH = 50
TSM =
{
}

@ckaotik
Copy link

ckaotik commented Jul 18, 2018

The MAX_CHANNEL_BUTTONS variable was removed, channel buttons are now iterable in ChannelFrame:GetList().buttons.
Due to the code comment above the affected section ("I have no idea why the channel list is getting fucked up but re-setting the font obj seems to fix it"), I tried removing the whole loop - it seems to no longer be necessary and resolves the error.

@Daeveren
Copy link

Chaotik, thanks for your input. Can you please help us, those with no programming knowledge? What exactly should we change in the .lua files? Should we simply do a find & replace for the 2 variables you mentioned?

@ckaotik
Copy link

ckaotik commented Jul 18, 2018

In tekticles.lua, remove lines 88-94.

The problems that code snippet was originally fixing might show up again, I haven't tested that extensively as I don't know the exact conditions. Regardless, removing this code should allow the addon to function for the remaining parts of the UI, even if the channel list reverts to an incorrect font inbetween.

@Daeveren
Copy link

Thanks @ckaotik, it seems no more errors (atleast so far).

@spiralofhope
Copy link

I didn't even realize I had examined that same code:

#18

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants