Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HTTP: Improve cookie handling #127

Open
Tectu opened this issue Dec 26, 2023 · 0 comments
Open

HTTP: Improve cookie handling #127

Tectu opened this issue Dec 26, 2023 · 0 comments
Labels
enhancement New feature or request

Comments

@Tectu
Copy link
Owner

Tectu commented Dec 26, 2023

The http::request constructor accepting an rvalue of the underlying beast request currently parses cookies. However, this doesn't really make sense. We should only parse cookies when we really need them. This should happen outside of the http::request type. We already have http::cookie_value for this.

Furthermore, the cookie handling between an http::request and an http::response should be the same. The same free standing functions can be used.
@Tectu Tectu added the enhancement New feature or request label Dec 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Tectu