Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HTML form: check for requires fields #116

Open
Tectu opened this issue Aug 18, 2022 · 2 comments
Open

HTML form: check for requires fields #116

Tectu opened this issue Aug 18, 2022 · 2 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@Tectu
Copy link
Owner

Tectu commented Aug 18, 2022

The malloy::html::form class should perform check regarding all fields marked as required when parsing via parse().
@Tectu Tectu added enhancement New feature or request good first issue Good for newcomers labels Aug 18, 2022
@Tectu
Copy link
Owner Author

Tectu commented Aug 21, 2022

Draft: f86a48d

@Tectu
Copy link
Owner Author

Tectu commented Aug 22, 2022

I'm not too happy with this initial draft.

I think it might be better to have a separate/dedicated function in html::form to perform this check. This separate function could return/provide more detailed information such as the list of fields which are missing values. A consumer could then use this information to notify the user appropriately about the missing required fields.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Tectu