Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not an issue but an enchance maybe. #3

Closed
LordDeimos666 opened this issue Sep 8, 2023 · 4 comments · Fixed by #5
Closed

Not an issue but an enchance maybe. #3

LordDeimos666 opened this issue Sep 8, 2023 · 4 comments · Fixed by #5
Labels
enhancement New feature or request

Comments

@LordDeimos666
Copy link

LordDeimos666 commented Sep 8, 2023

Just leaving the idea that while showing the title the script maybe can check if there is the anime already on sonarr and flag it as already there.

I mean to show it before adding the show. Not at the end (if possible).

@TecnoCreeper TecnoCreeper added the enhancement New feature or request label Sep 8, 2023
@TecnoCreeper
Copy link
Owner

TecnoCreeper commented Sep 8, 2023

you mean like having the option crossed out in the selection screen and something like (already added to Sonarr) next to the name of the anime?

@LordDeimos666
Copy link
Author

Yep like that

@TecnoCreeper
Copy link
Owner

TecnoCreeper commented Sep 10, 2023

I understand. The problem is that the script relies on a library called Pick to handle the selection screen and there is currently an open issue and pull request (aisk/pick#105) to add disabled items in options. I'll wait a little more to see if the feature will be implemented and if it won't I'll do something about it myself somehow.

Edit: might switch to one of these https://stackoverflow.com/a/76237650

@TecnoCreeper
Copy link
Owner

Replaced pick with https://github.com/tmbo/questionary, the suggested feature is now implemented.

@TecnoCreeper TecnoCreeper linked a pull request Sep 11, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants