Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fabric Port #13

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Fabric Port #13

wants to merge 5 commits into from

Conversation

shadowhunt22
Copy link

@shadowhunt22 shadowhunt22 commented May 17, 2024

My uncle needed a Fabric port for our server, and after some testing, I am finally making the pull request. This also solves #4.

The changes are as follows:

  • Converted the project from a Maven project to a Gradle project to better facilitate dependencies.
  • Created a Paper and Fabric subproject

Just to be clear, I put you and I as authors in the fabric.mod.json. File link.

Some other considerations:

  • Have a common API. Both Paper and Fabric use the same code to give BlueMap the player icon for Bedrock players. I know what needs to be done, but even after making a number of mods on the Fabric platform, I still don't understand how to do this. And even if I did, I don't have the time to do it anymore.

@TechnicJelle
Copy link
Owner

TechnicJelle commented May 18, 2024

Thank you for this PR! It looks very well-made.

Though I must mention I'm not too big of a fan of Gradle...
I understand it's the standard for fabric mods, though..

I hope to be able to test this soon™
Until then, could you maybe compile a build for this and put it on your fork's releases page?
So in the meantime, I can point people who need this to your fork, so they can download the Fabric version :)

@shadowhunt22
Copy link
Author

I sure can do!

@shadowhunt22
Copy link
Author

https://github.com/shadowhunt22/BlueMapFloodgate/releases/tag/v1.0.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants