Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding an .ips patch file for rom using the "Add More Games" button shows misleading prompt suggesting the ips file can be patched #429

Open
Bag-Head opened this issue Jun 25, 2022 · 0 comments
Assignees
Labels
bug Something isn't working

Comments

@Bag-Head
Copy link

Describe the bug
I stumbled into this entirely by accident, but if you happen to click an .ips patch file when using the "Add More Games" button, a pop up prompt appears stated the ips file you added can be patched and asks if you want to apply it. This gives the false impression that games already in your games list/games you're adding could be patched simply by adding the ips file to the games list and clicking "Yes" when the prompt appears, which you cannot do. Worth noting the pop up asks you if you want to patch the .ips file you added, which obviously cannot work and creates confusion that there possibly was a way to patch roms in the games list with this method.

To Reproduce

  1. Click "Add More Games" or Click "File", "Add Games"
  2. Click on any file in .ips format
  3. See pop up prompt stating "(insert filename).ips can be patched, do you want to apply the patch?"
  4. Clicking "Yes/Yes to all"
  5. Either shows no error message or in some cases does show an error, unsure why this is the case

Expected behavior
Simple version would be for a pop up prompt to instead inform user ips files cannot be applied by using the add games option and instead instruct them to working methods, such as adding the ips file to the "patches" folder with the rom's CRC32 at the start of the file name before adding the game, but ideally it would be a welcome feature if ips files could somehow be applied to games already in the games list either via "Add More Games" or a new "File, add ips file" option, could be further improved if this option allowed you to create a duplicate rom to patch and add a separate entry on the games list with the patch applied.

Additional context
I understand this is a very rare edge case as it's one I stumbled on by accident as well as this very well could not be addressed without negatively effecting the current patching method, but hopefully improvements could be made here as it would be very convenient if roms could be patched without having to remove and readd them to the games list after putting the desired patch in the patches folder and adding the CRC32 to the file name, it's quite a clunky method in my opinion.

@Bag-Head Bag-Head added the bug Something isn't working label Jun 25, 2022
@DanTheMan827 DanTheMan827 self-assigned this Nov 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants