Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Playback: omit any number of empty chords at the end of a score #28

Open
waldyrious opened this issue Sep 12, 2016 · 2 comments
Open

Playback: omit any number of empty chords at the end of a score #28

waldyrious opened this issue Sep 12, 2016 · 2 comments

Comments

@waldyrious
Copy link
Member

At the moment only the last one is omitted from playback.

@waldyrious waldyrious added this to the Version 1.0 milestone Sep 12, 2016
@elincognito
Copy link

At the moment it only makes sense to omit the last one since it's the only one with no specific chord, unless the user would "delete" the n-1 in that case he should also have the possibility to delete chords no ?

Btw i don't think this falls in the bug category

@waldyrious
Copy link
Member Author

If you start drawing a chord, then for some reason you remove its notes from the diagram, the chord after that will be present, so there will be 2 empty chords at the end of the score. One would expect the playback to ignore all of them, rather than have the hardcoded assumption that there will be a single empty chord at the end of a score. This already happens with the current version of the app, and works against expectations, hence the bug tag.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants