Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Playlist playback consistency #4887

Open
4 tasks done
rancidfrog opened this issue Nov 14, 2020 · 9 comments
Open
4 tasks done

Playlist playback consistency #4887

rancidfrog opened this issue Nov 14, 2020 · 9 comments
Labels
bug Issue is related to a bug good first issue Easy/simple issues perfect for newcomers to get involved in the project player Issues related to any player (main, popup and background)

Comments

@rancidfrog
Copy link

rancidfrog commented Nov 14, 2020

Checklist

Steps to reproduce the bug

  1. Open playlist with multiple entries

  2. Click on a video or long press a video and select 'start playing on pop-up' or long press and select 'start playing at background'

  3. For the first two, the app only plays selected/clicked video. Whereas background playback enqueues whole playlist playing selected files.

Actual behaviour

Clicking on a video or 'Start on pop-up' only plays selected file
'Start on background' enqueues playlist and plays selected file

Expected behavior

All three playback methods should have the same behaviour.
And since we are in a playlist it should follow the behaviour of 'Start playing in background', where selected file is played and the whole playlist is queued

Screenshots/Screen recordings

Device info

  • Android version/Custom ROM version: 10 / LineageOS 17.1
@rancidfrog rancidfrog added the bug Issue is related to a bug label Nov 14, 2020
@opusforlife2
Copy link
Collaborator

Clicking on a video or 'Start on pop-up' only plays selected file

Start on popup enqueues the whole playlist for me and plays from the selected stream.

Clicking on a single video and having it play is expected behaviour.

What is not expected is that Start in Background/Popup enqueues the whole playlist.

@opusforlife2 opusforlife2 added the player Issues related to any player (main, popup and background) label Nov 14, 2020
@rancidfrog
Copy link
Author

@opusforlife2
Yes, you are right.
'Start playing on pop-up' queues all playlist, too.
Thank you for this correction
I could not see playlist icon, which sometimes shows, sometimes not:

i guess not on pop-up anymore, but clicking notification brings you to queue

Clicking on a video should enqueue whole playlist, too.
As we are in playlist view, and clicking on an item should start playing item selected, but with loaded playlist (just like in youtube). That is the whole point of playlists.

Otherwise,
'Start playing in main player' is needed, with same behaviour as other 'start' buttons.

@triallax
Copy link
Contributor

I am using the latest version - x.xx.x

@rancidfrog did you perhaps forget to replace this?

@Stypox
Copy link
Member

Stypox commented Nov 17, 2020

Oh, there is an inconsistency here

@Stypox Stypox added the good first issue Easy/simple issues perfect for newcomers to get involved in the project label Nov 17, 2020
@rancidfrog
Copy link
Author

@Stypox
When clicking a video in a playlist, it should queue the playlist. The long press menu work for pop-up and background. But the only way to trigger main video is by clicking on the video (no long press entry), and clicking does not queue playlist even though we are in playlist view ...

[Just like in youtube, even though this is not youtube, but with trending and similar videos etc it sure looks that way]

Thank you for your time

@rancidfrog
Copy link
Author

Also,
If you start playback, i.e. background from sharing to newpipe.
Then it is not possible to add more videos to queue. As sharing again starts playing new video,
And opening newpipe long press on a video does not offer enqueue, only start play video

@dhruvpatidar359
Copy link
Contributor

Hello , i think this is an interesting issue , i am ready to work on it , please assign me .

@mayataylor233
Copy link

Hello, I'd like to work on this issue and I would appreciate if this issue was assigned to me.

@Stypox
Copy link
Member

Stypox commented Oct 12, 2024

@mayataylor233 the project is currently undergoing a refactor and will not accept non-essential PRs for some time, especially on difficult topics like this one. The long-press menus and playlist headers will be rewritten completely and with a better behavioural design.

Thank you for your interest though, if you want to help take a look at #11603 !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue is related to a bug good first issue Easy/simple issues perfect for newcomers to get involved in the project player Issues related to any player (main, popup and background)
Projects
None yet
Development

No branches or pull requests

6 participants