You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
IconicButtons.init calls ClickableWidget.getMessage on the partially initialized ClickableWidget passed in from MixinPressableWidget. This causes crashes in some mods, which haven't fully initialized their widgets yet. An example is World Host, where I haven't loaded the messages for the button yet, causing getMessage to NPE.
A potential solution would be to simply remove the IconicButtons.init call in MixinPressableWidget, and let renderIcons take care of it (which it will without any other changes, since it calls init if the text has changed, which it will have changed from null by the time it's called).
IconicButtons.init
callsClickableWidget.getMessage
on the partially initializedClickableWidget
passed in fromMixinPressableWidget
. This causes crashes in some mods, which haven't fully initialized their widgets yet. An example is World Host, where I haven't loaded the messages for the button yet, causinggetMessage
to NPE.A potential solution would be to simply remove the
IconicButtons.init
call inMixinPressableWidget
, and letrenderIcons
take care of it (which it will without any other changes, since it callsinit
if the text has changed, which it will have changed fromnull
by the time it's called).Fixing this will fix Gaming32/world-host#76.
The text was updated successfully, but these errors were encountered: