Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

51 bug ids get fails due to potential rate limiting or timeout #59

Open
wants to merge 12 commits into
base: main
Choose a base branch
from

Conversation

chriscarrollsmith
Copy link
Contributor

  • Adds exponential backoff in API calls
  • Consolidates multi-resource API calls by using semicolon separators rather than making a separate request for every resource
  • Minor enhancements to documentation, dependency management
  • Updates test suite

Copy link

codecov bot commented Dec 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (b6f1b9e) to head (6ce4a4b).

Additional details and impacted files
@@            Coverage Diff            @@
##              main       #59   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           10        10           
  Lines          235       267   +32     
=========================================
+ Hits           235       267   +32     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@chriscarrollsmith
Copy link
Contributor Author

Opened this as a draft PR because I still want to do a little manual stress-testing tomorrow to see whether there are upper limits on how many resources you can request by this method (and whether this actually solves Teal's problem!). But the test suite seems to be passing, at least!

@chriscarrollsmith chriscarrollsmith marked this pull request as ready for review December 10, 2024 15:46
Copy link
Collaborator

@christophscheuch christophscheuch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good to me, great improvement! I added validate_request_url() to be fully aligned with the API specs and hopefully prevent some edge cases.

EDIT: one more comment: I believe that comments in code are redundant because the code should be written self-explanatory. Only notes about seemingly odd choices should be explained (mostly for your future self). I'd thus remove the comments in ids_get(). Also, the comments smell like LLM :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: ids_get() fails due to potential rate-limiting or timeout
2 participants