-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
51 bug ids get fails due to potential rate limiting or timeout #59
base: main
Are you sure you want to change the base?
51 bug ids get fails due to potential rate limiting or timeout #59
Conversation
chriscarrollsmith
commented
Dec 9, 2024
- Adds exponential backoff in API calls
- Consolidates multi-resource API calls by using semicolon separators rather than making a separate request for every resource
- Minor enhancements to documentation, dependency management
- Updates test suite
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #59 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 10 10
Lines 235 267 +32
=========================================
+ Hits 235 267 +32 ☔ View full report in Codecov by Sentry. |
Opened this as a draft PR because I still want to do a little manual stress-testing tomorrow to see whether there are upper limits on how many resources you can request by this method (and whether this actually solves Teal's problem!). But the test suite seems to be passing, at least! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look good to me, great improvement! I added validate_request_url() to be fully aligned with the API specs and hopefully prevent some edge cases.
EDIT: one more comment: I believe that comments in code are redundant because the code should be written self-explanatory. Only notes about seemingly odd choices should be explained (mostly for your future self). I'd thus remove the comments in ids_get(). Also, the comments smell like LLM :D
…imiting-or-timeout