Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update sysdata.rda to new IDS release #53

Merged

Conversation

christophscheuch
Copy link
Collaborator

@christophscheuch christophscheuch commented Dec 5, 2024

Includes:

  • Removing countries and counterparts described in the issue: Enhancement: Update available geographies and counterparts to 2023 data #52
  • Ensuring NA values for some geography columns that were overlooked (they had "NA" character)
  • Taking the correct counterpart_type "Institution" which was mistakenly overwritten by "Other"
  • I also updated a bulk download test that failed due to outdated message text in the test

@christophscheuch christophscheuch added the enhancement New feature or request label Dec 5, 2024
@christophscheuch christophscheuch self-assigned this Dec 5, 2024
Copy link

codecov bot commented Dec 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (35a94fd) to head (355d926).
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main       #53   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           10        10           
  Lines          232       232           
=========================================
  Hits           232       232           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@t-emery
Copy link
Contributor

t-emery commented Dec 5, 2024

It looks like the Namibia (iso2c: "NA") problem strikes again! That's the reason I have such a strong preference for iso3c over iso2c.

I reviewed, and it all looks good.

@t-emery t-emery merged commit 680f432 into main Dec 5, 2024
10 checks passed
@chriscarrollsmith chriscarrollsmith deleted the 52-update-available-geographies-and-counterparts-to-2023-data branch December 6, 2024 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enhancement: Update available geographies and counterparts to 2023 data
2 participants