Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix failing tests in for ids_bulk due to gateway timeouts #36

Closed
christophscheuch opened this issue Nov 13, 2024 · 0 comments · Fixed by #37
Closed

Fix failing tests in for ids_bulk due to gateway timeouts #36

christophscheuch opened this issue Nov 13, 2024 · 0 comments · Fixed by #37
Assignees
@christophscheuch
Labels
bug Something isn't working

Comments

@christophscheuch
Copy link
Collaborator

christophscheuch commented Nov 13, 2024 •
edited
Loading

Need to handle 504 errors because R-CMD-CHECK sometimes fails on GitHub Actions:

── Error ('test-ids_bulk.R:107:3'): ids_bulk handles timeout parameter correctly ──
<httr2_http_504/httr2_http/httr2_error/rlang_error/error/condition>
Error in `httr2::req_perform(httr2::req_headers(httr2::request(file_url), 
    Accept = "*/*"))`: HTTP 504 Gateway Timeout.
@christophscheuch christophscheuch added the bug Something isn't working label Nov 13, 2024
@christophscheuch christophscheuch self-assigned this Nov 14, 2024
@christophscheuch christophscheuch linked a pull request Nov 14, 2024 that will close this issue
Add multiple attempts to ids_bulk test for handling timeout parameter #37
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@christophscheuch christophscheuch

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add multiple attempts to ids_bulk test for handling timeout parameter Teal-Insights/r-wbids
1 participant
@christophscheuch