Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Non expanded children are build lazy #2

Open
zellidev0 opened this issue Jun 10, 2024 · 2 comments · May be fixed by #4
Open

Non expanded children are build lazy #2

zellidev0 opened this issue Jun 10, 2024 · 2 comments · May be fixed by #4
Labels
enhancement New feature or request

Comments

@zellidev0
Copy link

Hi,

I'm using the package for a expandable Tree structure, that's indefinitely nested.
It looks to me that the widget does not build the children widgets lazily.

Am I correct in this assumption?
And if so, is there a reason for that?

Wouldn't it be beneficial, if the widgets that are expanded would only be build, when they are expanded?

Thanks.

@Amir-P
Copy link
Member

Amir-P commented Jun 10, 2024

Hi! Thanks for pointing it out. Right now, not only the sliver will be built even if it's not expanded, in case of something like SliverList, the children gets built too based on the offset. I haven't found the time to do the optimizations and surely there's a lot to do. I will work on them but in the meantime feel free to contribute.

@Amir-P Amir-P added the enhancement New feature or request label Jun 10, 2024
@zellidev0 zellidev0 changed the title (question) - Are the non expanded children build lazy Non expanded children are build lazy Jun 11, 2024
@Amir-P Amir-P linked a pull request Jan 11, 2025 that will close this issue
@Amir-P
Copy link
Member

Amir-P commented Jan 11, 2025

I believe #4 fixes this issue. Could you please give it a try and verify the fix? @zellidev0

  sliver_expandable:
    git:
      url: https://github.com/Taskulu/sliver_expandable
      ref: feat/layout_sliver_only_when_expanded

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants