-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Homepage Card Animation #391
Homepage Card Animation #391
Conversation
@Tanay-ErrorCode @Doraemon012 Please review this and let me know if any changes |
@Ayushmaanagarwal1211 Fix the issues in layout.
|
@Tanay-ErrorCode i fixed that but if it is not fixed please send the screen size i will work on that accordingly |
Fix this. 2024-08-04.17-53-43.mp4 |
bandicam.2024-08-04.19-15-14-133.mp4@Tanay-ErrorCode i applied this animation to every image please check and it is changing the z-index on hovering |
These two are still remaining. |
@Tanay-ErrorCode I am a little bit confuse Like i have added this blink animation to all those cards so i am sharing a video please see that and tell me where i am doing wrong so that i can fix it accordingly bandicam.2024-08-04.22-30-15-713.mp4 |
Analogy ExplanationImagine you have a stack of cards, each with a different importance level. The most important card is on top, and the least important is at the bottom. The importance of each card is represented by its z-index, which determines how "in front" the card appears compared to others.
SummaryIn essence, when you hover over a card, it takes the topmost position in terms of visibility (highest z-index), pushing down the previously topmost card and adjusting the visibility (z-index) of all other cards. This dynamic reordering ensures the hovered card is always most prominent. Kindly fix it accordingly. |
@Tanay-ErrorCode Ohk ok now i understood fixing this |
@Tanay-ErrorCode Please check bandicam.2024-08-05.10-18-36-062.mp4 |
@Ayushmaanagarwal1211 This is good. You need to fix the blinking problem, i.e. opacity first becomes 0 and then increases. We need something like this: 2024-08-05.11-02-58.mp4 |
@Tanay-ErrorCode If i understood clearly you are saying this bandicam.2024-08-05.11-26-40-434.mp4 |
@Ayushmaanagarwal1211 Observer the moment when the opacity becomes 0 just after hovering it. We don't need this type of blink My.Video1.mp4 |
@Tanay-ErrorCode should i remove the opacity from 0 to 1 |
@Ayushmaanagarwal1211 Make it similar to the video I provided. |
Ok |
@Tanay-ErrorCode please check again i fixed that |
bandicam.2024-08-05.20-50-18-800.mp4 |
@Ayushmaanagarwal1211 The latest commit isnt working, seems like some mistake, kindly fix it. |
@Ayushmaanagarwal1211 Any updates? |
@Tanay-ErrorCode yes I am fixing error please give me time for today |
@Tanay-ErrorCode I fixed that check again |
@Ayushmaanagarwal1211 Can you fix this image going out of the screen? |
@Tanay-ErrorCode i fixed that please check i reduced the sized of the images to minimum |
@Tanay-ErrorCode please check |
@Tanay-ErrorCode what happened |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Ayushmaanagarwal1211 Please adjust the size according to the website.
What kind of change does this PR introduce?
I have break the single image into different components and configured each image seperately and added animations to all images
I have also fixed the zindex so that when user hover on the image so the image looks like popping up
Issue Number: #390
Fixes #390
Snapshots/Videos:
bandicam.2024-08-04.17-02-03-384.mp4
bandicam.2024-08-04.16-54-57-796.mp4
bandicam.2024-08-04.17-02-38-117.mp4
Other information