-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable The Renderer to Handle 4+ texts #14
Comments
I think it's a good problem to solve, yet we first need to come up with some sketches as to what that would look like.
|
Agree with these questions. We could start with our library and extend it to more texts, but when we move away from duplicating the Vilna, we lose the guarantee that our formatting is useful. Alternatively, we could start with a layout that we are more confident is useful, but then we must reevaluate whether our library is the best tool for the job. |
Another option is to create another library that is not just for the vilna, then we could focus on what looks best for wrapping texts. |
@Shaun-Regenbaum I think that's the best approach; i.e. have a separate API designed for Mikraot Gedolot style layouts. Examples of a daf-like object inside a Mikraot Gedolot-style layout include Mishnah Berurah with Be'ur Halacha (in my version at least), Siftei Chachamim with Rashi, and Onkelos with Psukim. But this doesn't happen the other way around, so it'd make sense to have the Mikraot Gedolot library be (optionally) composed of daf-renderers. |
Sounds, good so after I implement tests, Ill close this issue and open a new library. |
As of right now the renderer can reliably handle 1 (?), 2, or 3 texts, no matter their size. Yet, there may be people who want to be able to wrap together 4, 5, or more texts.
The text was updated successfully, but these errors were encountered: