From 2638257156c69ef75752aa968926583c7076adf9 Mon Sep 17 00:00:00 2001 From: liangfung Date: Tue, 7 Jan 2025 23:18:42 +0800 Subject: [PATCH] update --- .../sso/components/credential-list.tsx | 2 +- .../sso/components/form-sub-title.tsx | 4 +--- .../sso/components/ldap-credential-form.tsx | 20 ++++--------------- .../sso/components/oauth-credential-form.tsx | 4 ++-- 4 files changed, 8 insertions(+), 22 deletions(-) diff --git a/ee/tabby-ui/app/(dashboard)/settings/(integrations)/sso/components/credential-list.tsx b/ee/tabby-ui/app/(dashboard)/settings/(integrations)/sso/components/credential-list.tsx index 4872fb76c060..75546ade4069 100644 --- a/ee/tabby-ui/app/(dashboard)/settings/(integrations)/sso/components/credential-list.tsx +++ b/ee/tabby-ui/app/(dashboard)/settings/(integrations)/sso/components/credential-list.tsx @@ -197,7 +197,7 @@ const LDAPCredentialCard = ({ LDAP
- Domain + Host {data?.host}
diff --git a/ee/tabby-ui/app/(dashboard)/settings/(integrations)/sso/components/form-sub-title.tsx b/ee/tabby-ui/app/(dashboard)/settings/(integrations)/sso/components/form-sub-title.tsx index ad48463e4307..fc9ec7a96a69 100644 --- a/ee/tabby-ui/app/(dashboard)/settings/(integrations)/sso/components/form-sub-title.tsx +++ b/ee/tabby-ui/app/(dashboard)/settings/(integrations)/sso/components/form-sub-title.tsx @@ -4,7 +4,5 @@ export function SubTitle({ className, ...rest }: React.HTMLAttributes) { - return ( -
- ) + return
} diff --git a/ee/tabby-ui/app/(dashboard)/settings/(integrations)/sso/components/ldap-credential-form.tsx b/ee/tabby-ui/app/(dashboard)/settings/(integrations)/sso/components/ldap-credential-form.tsx index 33248991428a..6dd8d39afa53 100644 --- a/ee/tabby-ui/app/(dashboard)/settings/(integrations)/sso/components/ldap-credential-form.tsx +++ b/ee/tabby-ui/app/(dashboard)/settings/(integrations)/sso/components/ldap-credential-form.tsx @@ -152,13 +152,6 @@ export function LDAPCredentialForm({ const deleteLdapCredential = useMutation(deleteLdapCredentialMutation) const onSubmit = async (values: LDAPFormValues) => { - const hasPassword = !isEmpty(values.bindPassword) - // test ldap connection - // if (submitTypeRef.current === 'test') { - // return testLdapConnection({ input: values }) - - // } - // update ldap credential if (isNew) { const hasExistingProvider = await client @@ -170,11 +163,6 @@ export function LDAPCredentialForm({ }) return } - - if (!hasPassword) { - form.setError('bindPassword', { message: 'Required' }) - return - } } return updateOauthCredential({ input: values }) } @@ -285,7 +273,7 @@ export function LDAPCredentialForm({ Bind DN Base DN User Filter )} /> -
+
User information mapping Maps the field names from user info API to the Tabby user. diff --git a/ee/tabby-ui/app/(dashboard)/settings/(integrations)/sso/components/oauth-credential-form.tsx b/ee/tabby-ui/app/(dashboard)/settings/(integrations)/sso/components/oauth-credential-form.tsx index 22ad77e65244..7915376d45a0 100644 --- a/ee/tabby-ui/app/(dashboard)/settings/(integrations)/sso/components/oauth-credential-form.tsx +++ b/ee/tabby-ui/app/(dashboard)/settings/(integrations)/sso/components/oauth-credential-form.tsx @@ -173,7 +173,7 @@ export default function OAuthCredentialForm({
- Basic information + Basic information )} -
+
OAuth provider information The information is provided by your identity provider.