Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Filter for versions is incomplete #14

Open
maddy2101 opened this issue May 9, 2021 · 2 comments
Open

Filter for versions is incomplete #14

maddy2101 opened this issue May 9, 2021 · 2 comments
Assignees
@soee
Labels
todo

Comments

@maddy2101
Copy link

I searched for a string, got a ton of results, and each has the corresponding version strings applied. Great!

But looking into the sidebar for filters to narrow down the result, I find not all versions from the search result list are available here.

Search-results-for-import
@tmotyl
Copy link
Collaborator

tmotyl commented May 11, 2021

Hi @maddy2101
Right now we're showing only first 10 buckets with highest number of found documents.
Seems that v10.4 had less than 52 documents found, so it was not in the top 10 Versions.
I can of course increase the number of versions shown, but this will not solve the problem (you might have 100 version shown).

@DavidBruchmann
Copy link

Perhaps it's possible to add additional buckets only for the main versions, so that subversions could be ignored?

@tmotyl tmotyl added the todo label Dec 6, 2023
@soee soee self-assigned this Dec 19, 2023
soee pushed a commit to soee/t3docs-search-indexer that referenced this issue Dec 29, 2023
TYPO3-Documentation#14 Aggregate only major versions and render label…
237710d 
…s for highest versions

This commit replaces the all versions aggregation by only major versions.

There is also change for the search results list. Before labels for all versions assigned to the snippet were rendered. After the changes only
the highest version in given branch will be rendered. For example, if
snippet has versions `main`, `12.4`, `12.0`, `11.5`, `11.3`, `11.0`, `9.5`, only labels for
`main`,`12.4`, `11.5`, `9.5` will be rendered.

Resolves issue: TYPO3-Documentation#14
@soee soee mentioned this issue Dec 29, 2023
Merged
soee pushed a commit to soee/t3docs-search-indexer that referenced this issue Feb 15, 2024
TYPO3-Documentation#14 Aggregate only major versions and render label…
ca6a00e 
…s for highest versions

This commit replaces the all versions aggregation by only major versions.

There is also change for the search results list. Before labels for all versions assigned to the snippet were rendered. After the changes only
the highest version in given branch will be rendered. For example, if
snippet has versions `main`, `12.4`, `12.0`, `11.5`, `11.3`, `11.0`, `9.5`, only labels for
`main`,`12.4`, `11.5`, `9.5` will be rendered.

Resolves issue: TYPO3-Documentation#14
soee pushed a commit to soee/t3docs-search-indexer that referenced this issue Feb 16, 2024
TYPO3-Documentation#14 Aggregate only major versions and render label…
f53d5ee 
…s for highest versions

This commit replaces the all versions aggregation by only major versions.

There is also change for the search results list. Before labels for all versions assigned to the snippet were rendered. After the changes only
the highest version in given branch will be rendered. For example, if
snippet has versions `main`, `12.4`, `12.0`, `11.5`, `11.3`, `11.0`, `9.5`, only labels for
`main`,`12.4`, `11.5`, `9.5` will be rendered.

Resolves issue: TYPO3-Documentation#14
linawolf added a commit that referenced this issue Feb 16, 2024
@linawolf
Merge pull request #58 from soee/addMainVersionAggrAndRenderOnlyHighe…
6eb5b3d 
…stVersionsLabels

#14 Aggregate only major versions and render labels for highest versions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@soee soee

Labels
todo
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@tmotyl @DavidBruchmann @soee @maddy2101