From 4d7e687f82d2b9b91add344ea64dae8ffa6ace4a Mon Sep 17 00:00:00 2001 From: "lina.wolf" Date: Mon, 26 Aug 2024 13:55:12 +0200 Subject: [PATCH 1/2] [BUGFIX] Remove rector for version 12.4 It currently throws errors and makes the tests red without reason. Releases: 12.4 --- .github/workflows/tests.yml | 3 --- 1 file changed, 3 deletions(-) diff --git a/.github/workflows/tests.yml b/.github/workflows/tests.yml index 25cd172..b326dac 100644 --- a/.github/workflows/tests.yml +++ b/.github/workflows/tests.yml @@ -43,9 +43,6 @@ jobs: - name: CGL run: Build/Scripts/runTests.sh -n -p ${{ env.php }} -s cgl - - name: Rector - run: Build/Scripts/runTests.sh -n -p ${{ env.php }} -s rector - - name: PHPStan run: Build/Scripts/runTests.sh -p ${{ env.php }} -s phpstan From 7afaefea39f2c0bd31bde0f5f2acca7c454d5f08 Mon Sep 17 00:00:00 2001 From: "lina.wolf" Date: Mon, 26 Aug 2024 13:59:53 +0200 Subject: [PATCH 2/2] [BUGFIX] Fix CGL Releases: 12.4 --- Classes/Controller/ModuleController.php | 1 - 1 file changed, 1 deletion(-) diff --git a/Classes/Controller/ModuleController.php b/Classes/Controller/ModuleController.php index 41eada5..8683a8c 100644 --- a/Classes/Controller/ModuleController.php +++ b/Classes/Controller/ModuleController.php @@ -52,7 +52,6 @@ */ class ModuleController extends ActionController { - private int $pageUid; /** @var array */ private array $exampleConfig;