From 5e4e5b5fb3993d9e5ed0ca0ef64f494beb0e342a Mon Sep 17 00:00:00 2001 From: "lina.wolf" Date: Fri, 3 May 2024 10:18:39 +0200 Subject: [PATCH] [TASK] Apply suggestions from code review --- Makefile | 8 ++++++++ ext_emconf.php | 9 ++++----- rector.php | 3 +-- 3 files changed, 13 insertions(+), 7 deletions(-) diff --git a/Makefile b/Makefile index 02cc8ba..6070f15 100644 --- a/Makefile +++ b/Makefile @@ -12,3 +12,11 @@ docs: ## Generate projects documentation (from "Documentation" directory) test-docs: ## Test the documentation rendering mkdir -p Documentation-GENERATED-temp docker run --rm --pull always -v "$(shell pwd)":/project -t ghcr.io/typo3-documentation/render-guides:latest --config=Documentation --no-progress --fail-on-log + +.PHONY: rector +rector: ## Run rector + .Build/bin/rector + +.PHONY: fix-cs +fix-cs: ## Fix PHP coding styles + .Build/bin/php-cs-fixer fix --config=.php-cs-fixer.dist.php diff --git a/ext_emconf.php b/ext_emconf.php index e10c265..9167476 100644 --- a/ext_emconf.php +++ b/ext_emconf.php @@ -24,11 +24,10 @@ 'version' => '13.0.0', 'constraints' => [ 'depends' => [ - 'php' => '8.2.0-8.99.99', - 'typo3' => '13.1.0-13.99.99', - 'impexp' => '13.1.0-13.99.99', - 'fluid_styled_content' => '13.1.0-13.99.99', - 'linkvalidator' => '13.1.0-13.99.99', + 'typo3' => '13.1.0-13.4.99', + 'impexp' => '13.1.0-13.4.99', + 'fluid_styled_content' => '13.1.0-13.4.99', + 'linkvalidator' => '13.1.0-13.4.99', ], 'conflicts' => [], 'suggests' => [], diff --git a/rector.php b/rector.php index 3acf7dd..fbde0d0 100644 --- a/rector.php +++ b/rector.php @@ -48,8 +48,7 @@ ConvertImplicitVariablesToExplicitGlobalsRector::class, ]) ->withConfiguredRule(ExtEmConfRector::class, [ - ExtEmConfRector::PHP_VERSION_CONSTRAINT => '8.2.0-8.99.99', - ExtEmConfRector::TYPO3_VERSION_CONSTRAINT => '13.1.0-13.99.99', + ExtEmConfRector::TYPO3_VERSION_CONSTRAINT => '13.1.0-13.4.99', ExtEmConfRector::ADDITIONAL_VALUES_TO_BE_REMOVED => [], ]) ->withSkip([