Skip to content

Commit

Permalink
[TASK] Apply suggestions from code review
Browse files Browse the repository at this point in the history
  • Loading branch information
linawolf committed May 3, 2024
1 parent 59164bf commit 5e4e5b5
Show file tree
Hide file tree
Showing 3 changed files with 13 additions and 7 deletions.
8 changes: 8 additions & 0 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -12,3 +12,11 @@ docs: ## Generate projects documentation (from "Documentation" directory)
test-docs: ## Test the documentation rendering
mkdir -p Documentation-GENERATED-temp
docker run --rm --pull always -v "$(shell pwd)":/project -t ghcr.io/typo3-documentation/render-guides:latest --config=Documentation --no-progress --fail-on-log

.PHONY: rector
rector: ## Run rector
.Build/bin/rector

.PHONY: fix-cs
fix-cs: ## Fix PHP coding styles
.Build/bin/php-cs-fixer fix --config=.php-cs-fixer.dist.php
9 changes: 4 additions & 5 deletions ext_emconf.php
Original file line number Diff line number Diff line change
Expand Up @@ -24,11 +24,10 @@
'version' => '13.0.0',
'constraints' => [
'depends' => [
'php' => '8.2.0-8.99.99',
'typo3' => '13.1.0-13.99.99',
'impexp' => '13.1.0-13.99.99',
'fluid_styled_content' => '13.1.0-13.99.99',
'linkvalidator' => '13.1.0-13.99.99',
'typo3' => '13.1.0-13.4.99',
'impexp' => '13.1.0-13.4.99',
'fluid_styled_content' => '13.1.0-13.4.99',
'linkvalidator' => '13.1.0-13.4.99',
],
'conflicts' => [],
'suggests' => [],
Expand Down
3 changes: 1 addition & 2 deletions rector.php
Original file line number Diff line number Diff line change
Expand Up @@ -48,8 +48,7 @@
ConvertImplicitVariablesToExplicitGlobalsRector::class,
])
->withConfiguredRule(ExtEmConfRector::class, [
ExtEmConfRector::PHP_VERSION_CONSTRAINT => '8.2.0-8.99.99',
ExtEmConfRector::TYPO3_VERSION_CONSTRAINT => '13.1.0-13.99.99',
ExtEmConfRector::TYPO3_VERSION_CONSTRAINT => '13.1.0-13.4.99',
ExtEmConfRector::ADDITIONAL_VALUES_TO_BE_REMOVED => [],
])
->withSkip([
Expand Down

0 comments on commit 5e4e5b5

Please sign in to comment.