[TASK] Apply suggestions from code review

TYPO3-Documentation · May 3, 2024 · 59164bf · 59164bf
1 parent db82128
commit 59164bf
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 33 deletions.
diff --git a/Configuration/Backend/AjaxRoutes.php b/Configuration/Backend/AjaxRoutes.php
@@ -15,18 +15,6 @@
 
 use T3docs\Examples\Controller\ModuleController;
 
-/*
- * This file is part of the TYPO3 CMS project.
- *
- * It is free software; you can redistribute it and/or modify it under
- * the terms of the GNU General Public License, either version 2
- * of the License, or any later version.
- *
- * For the full copyright and license information, please read the
- * LICENSE.txt file that was distributed with this source code.
- *
- * The TYPO3 project - inspiring people to share!
- */
 return [
     'tx_examples_count' => [
         'path' => '/examples/module/count',

diff --git a/Configuration/RequestMiddlewares.php b/Configuration/RequestMiddlewares.php
@@ -15,18 +15,6 @@
 
 use T3docs\Examples\Middleware\HaikuSeasonList;
 
-/*
- * This file is part of the TYPO3 CMS project.
- *
- * It is free software; you can redistribute it and/or modify it under
- * the terms of the GNU General Public License, either version 2
- * of the License, or any later version.
- *
- * For the full copyright and license information, please read the
- * LICENSE.txt file that was distributed with this source code.
- *
- * The TYPO3 project - inspiring people to share!
- */
 return [
     'frontend' => [
         't3docs/examples/haiku-season-list' => [

diff --git a/ext_emconf.php b/ext_emconf.php
@@ -24,10 +24,11 @@
     'version' => '13.0.0',
     'constraints' => [
         'depends' => [
-            'typo3' => '13.1.0-13.4.99',
-            'impexp' => '13.0.0-13.4.99',
-            'fluid_styled_content' => '13.0.0-13.4.99',
-            'linkvalidator' => '13.0.0-13.4.99',
+            'php' => '8.2.0-8.99.99',
+            'typo3' => '13.1.0-13.99.99',
+            'impexp' => '13.1.0-13.99.99',
+            'fluid_styled_content' => '13.1.0-13.99.99',
+            'linkvalidator' => '13.1.0-13.99.99',
         ],
         'conflicts' => [],
         'suggests' => [],

diff --git a/rector.php b/rector.php
@@ -19,7 +19,6 @@
 use Rector\Php74\Rector\LNumber\AddLiteralSeparatorToNumberRector;
 use Rector\TypeDeclaration\Rector\ClassMethod\AddVoidReturnTypeWhereNoReturnRector;
 use Rector\TypeDeclaration\Rector\ClassMethod\ReturnNeverTypeRector;
-use Rector\ValueObject\PhpVersion;
 use Ssch\TYPO3Rector\CodeQuality\General\ConvertImplicitVariablesToExplicitGlobalsRector;
 use Ssch\TYPO3Rector\CodeQuality\General\ExtEmConfRector;
 use Ssch\TYPO3Rector\Configuration\Typo3Option;
@@ -30,12 +29,11 @@
     ->withPaths([
         __DIR__ . '/.',
     ])
-    ->withImportNames()
+    ->withImportNames(true, true, false, true)
     ->withPhpSets()
     ->withAutoloadPaths([
         __DIR__ . '/.Build/vendor/autoload.php',
     ])
-    ->withPhpVersion(PhpVersion::PHP_82)
     ->withSets([
         Typo3SetList::CODE_QUALITY,
         Typo3SetList::GENERAL,
@@ -50,8 +48,8 @@
         ConvertImplicitVariablesToExplicitGlobalsRector::class,
     ])
     ->withConfiguredRule(ExtEmConfRector::class, [
-        ExtEmConfRector::PHP_VERSION_CONSTRAINT => '8.2.0-8.3.99',
-        ExtEmConfRector::TYPO3_VERSION_CONSTRAINT => '13.1.0-13.4.99',
+        ExtEmConfRector::PHP_VERSION_CONSTRAINT => '8.2.0-8.99.99',
+        ExtEmConfRector::TYPO3_VERSION_CONSTRAINT => '13.1.0-13.99.99',
         ExtEmConfRector::ADDITIONAL_VALUES_TO_BE_REMOVED => [],
     ])
     ->withSkip([