Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reading from a non existing cell does not work #28

Closed
cpaulik opened this issue Feb 26, 2016 · 0 comments · Fixed by #29
Closed

Reading from a non existing cell does not work #28

cpaulik opened this issue Feb 26, 2016 · 0 comments · Fixed by #29

Comments

@cpaulik
Copy link
Collaborator

cpaulik commented Feb 26, 2016

Reading from a non existing cell works only for the first gpi of the cell.
For the second gpi in a cell if self.previous_cell != cell: is False which means that success is True even when the file does not exist.

The relevant code is here.

We really have to fix #20 to avoid stuff like that.
cpaulik pushed a commit that referenced this issue Feb 26, 2016
Fix #28 by resetting cell number only when the file exists.
4b5b70b
@cpaulik cpaulik mentioned this issue Feb 26, 2016
Merged
sebhahn added a commit that referenced this issue Feb 26, 2016
@sebhahn
Merge pull request #29 from TUW-GEO/fix-empty-cell-reading
da9bc82 
Fix #28 by resetting cell number only when the file exists.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix #28 by resetting cell number only when the file exists. TUW-GEO/pygeobase
1 participant
@cpaulik