Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TTT Localization Lines #1654

Open
NovaDiablox opened this issue Oct 1, 2024 · 2 comments
Open

TTT Localization Lines #1654

NovaDiablox opened this issue Oct 1, 2024 · 2 comments

Comments

@NovaDiablox
Copy link
Contributor

Is your feature request related to a problem? Please describe.

The lines 161-166 should be full sentences. It causes weird and incorrect translations.

Describe the solution you'd like

Make it full sentences instead of word groups.

Additional context

Word groups make localization harder due to not every language is suitable for it. Full sentences are better in this context. This problem also exists in default TTT.

@TimGoll TimGoll added this to the Feature Backlog milestone Oct 1, 2024
@TimGoll TimGoll added the type/enhancement Enhancement or simple change to existing functionality label Oct 1, 2024
@Histalek Histalek removed the type/enhancement Enhancement or simple change to existing functionality label Oct 2, 2024
@Histalek
Copy link
Member

I can understand where you are coming from, but these lines specifically replace a player's nickname in the language strings in the lines above.

We could probably make the comment above those lines more clearly understandable or provide better context.

To follow through with your request otherwise we would need to duplicate the above language strings four times and fix the code that's using these strings accordingly

@NovaDiablox
Copy link
Contributor Author

I can understand where you are coming from, but these lines specifically replace a player's nickname in the language strings in the lines above.

We could probably make the comment above those lines more clearly understandable or provide better context.

To follow through with your request otherwise we would need to duplicate the above language strings four times and fix the code that's using these strings accordingly

I believe it is possible to add new lines for those situations with respected {} in them. We just need them seperately, not linked between strings. I want to keep the player's nickname function.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants