Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix includeMetaKIs(...) call in ReasonerProcessor. #535

Closed
bnouwt opened this issue Sep 6, 2024 · 1 comment · Fixed by #538
Closed

Fix includeMetaKIs(...) call in ReasonerProcessor. #535

bnouwt opened this issue Sep 6, 2024 · 1 comment · Fixed by #538
Assignees

Comments

@bnouwt
Copy link
Collaborator

bnouwt commented Sep 6, 2024

Currently, in the ReasonerProcessor, we call the includeMetaKIs(...) method to determine whether to use ENTRY or NORMAL reasoning mode. However, this is wrong, because this should not depend on whether the meta KIs should be included, it should rather be depending on whether the KI isMeta(). However, if we do that, the MockedKnowledgeBase and KnowledgeNetwork usage fails because they use the meta Graph Pattern (but are not meta KIs), but still would not like to use NORMAL reasoning mode since this causes an OutOfMemoryException.

So, we need to think about how we want the reasoner configuration to work. Maybe we should introduce the levels ENTRY, NORMAL, ADVANCED, ULTIMATE and SUPREME in the knowledge-engine artifact. In the reasoner artifact we can only use the MatchFlags in the reasoner.

@bnouwt
Copy link
Collaborator Author

bnouwt commented Sep 10, 2024

Did the above. Next up is making sure we can configure the reasoner correctly.

Do I also want to include configuration via REST API? That is maybe also part of #533

@bnouwt bnouwt self-assigned this Sep 11, 2024
@bnouwt bnouwt linked a pull request Sep 11, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant