Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Autograd of superloss #1

Open
yuanpinz opened this issue Jun 27, 2023 · 1 comment
Open

Autograd of superloss #1

yuanpinz opened this issue Jun 27, 2023 · 1 comment

Comments

@yuanpinz
Copy link

I've noticed the superloss implementation is similar with AlanChou's unoffical implementation (https://github.com/AlanChou/Super-Loss). Both of which used scipy to calculate lambertw. However, as stated in AlanChou's implementation, quoted:

The labertw function should be implemented with PyTorch instead of using the scipy library as mentioned in AlanChou/Truncated-Loss#3 (comment).

There is a mistake because the additive regularization part doesn't have any gradients for Autograd.

Does this implementation solve the above problem?

@RishabhMaheshwary
Copy link

RishabhMaheshwary commented Jul 4, 2023

There are some implementations of lambertw using pytorch as mentioned here pytorch/pytorch#49851 (comment).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants