Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(top-menu): Replace the banner by the news #1409

Open
4 tasks
WaDadidou opened this issue Nov 22, 2024 · 0 comments
Open
4 tasks

fix(top-menu): Replace the banner by the news #1409

WaDadidou opened this issue Nov 22, 2024 · 0 comments
Labels
bug Something isn't working enhancement New feature or request good first issue Good for newcomers UX/UI

Comments

@WaDadidou
Copy link
Collaborator

WaDadidou commented Nov 22, 2024

Bellow, Here is a screenshot of the Home screen with the TopMenu open.
In the TopMenu, at "Highlighted News", the Home banner is shown instead of the news, that's wrong.
The news to use are the same data than on the Home page: https://github.com/TERITORI/teritori-dapp/blob/chore-thumbnail-media/packages/components/carousels/NewsCarouselSection.tsx#L22

You have to :

Take attention to the existing components before making new ones, and ask information if you need :)

Image

  • Red: Current wrong state
  • Green: What it should be
@WaDadidou WaDadidou added bug Something isn't working enhancement New feature or request good first issue Good for newcomers UX/UI labels Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request good first issue Good for newcomers UX/UI
Projects
None yet
Development

No branches or pull requests

1 participant