Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

2 ecs sparsearrayclass #34

Merged
merged 59 commits into from
Oct 3, 2022
Merged

2 ecs sparsearrayclass #34

merged 59 commits into from
Oct 3, 2022

Conversation

Bootoyka
Copy link
Contributor

@Bootoyka Bootoyka commented Oct 2, 2022

ECS GLOBAL PARTS

This Pull Request delivers the global part of the ecs containing these following sub parts :

  • Entity
  • Registry
  • SparseArray
  • Example of component + architecture

This Pull Request allows the follwing feature

Component :

  • Register component
  • Delete component
  • Insert component
  • emplace component with defined value
  • Iterator & vector manager

Registry:

  • Component manager
  • Spawn Entity
  • Kill Entity

Please pay attention to the documentation and read it clearfully.

EmileEttel and others added 30 commits September 24, 2022 16:53
@EmileEttel
feat: added sparseArray.hpp with sparse_array class
3efe795
@EmileEttel
merge: merge with update
25c3150
@aurelenc
feat: implement missing members of sparseArray
d4c3e1d
@Bootoyka
build: replace INCROOT by absolute path to the directory of ecs folder
f3c2846
@Bootoyka
Revert "build: replace INCROOT by absolute path to the directory of e…
c4aa031 
…cs folder"

This reverts commit f3c2846.
@aurelenc
refactor: change sparse_array to SparseArray
7c00cbf
@aurelenc
feat: add basic registry
d1599b2
@aurelenc
feat: add entity class
0999c86
@aurelenc
feat: spawn, kill, add and remove entities from registry
76437e7 
/!\ add_component is weird and may cause crashes, working on it
@aurelenc
fix: CompilerFlags
8691057
@Bootoyka
refactor: merge 4 "build cmake architecture" pull request
8ddb0f4
@Bootoyka
refactor: merge from lasts commits
272e20f
@Bootoyka
Merge remote-tracking branch 'origin/2-ecs-sparsearrayclass' into 2-e…
dae023a 
…cs-sparsearrayclass
@Bootoyka
refactor: merge "4 build cmake architecture" pull request
d92aaa6
@aurelenc
fix: registry not adding or removing components
1047c9d
@Bootoyka
build: add Units tests CMakeLists.txt
1effeb8
@Bootoyka
misc: change main to default hello world main
3a2f6a2
@Bootoyka
misc: add targets in .gitignore
5bcb1a5
@Bootoyka
test: add basic cr_assert_eq to prove that it works
c2854e3
@aurelenc
Merge branch '2-ecs-sparsearrayclass' of github.com:TEAM-AAAAAAAAAAAA…
9a4fea3 
…AAAA/RTYPE into 2-ecs-sparsearrayclass
@aurelenc
refactor: remove debug on SparseArray
28e7674
@aurelenc
refactor: spawn_entity stack is empty
e16fc73
@aurelenc
feat: add PoC InputMoveUp component
a52cf6a
@Cavonstavant
feat: add Registry::kill_entity
76161dd
@aurelenc
feat: registry emplace component
296d60e
@aurelenc
feat: implement entity_from_index
6d5d106 
entity recycle bin is now a vector
@aurelenc
fix: return npos instead of throw when entity is not alive in registry
00132da
@aurelenc
feat: implement emplace_at in SparseArray
fe2521d
@aurelenc
fix: return npos instead of throw when entity is not alive in registry
c1d17b4
@aurelenc
feat: add Entity::npos
3194e81
@Bootoyka Bootoyka linked an issue Oct 2, 2022 that may be closed by this pull request
ECS-SparseArrayClass #2
Closed
4 tasks
@Bootoyka Bootoyka requested review from Cavonstavant, aurelenc and a team and removed request for aurelenc and Cavonstavant October 2, 2022 17:21
@Cavonstavant Cavonstavant linked an issue Oct 2, 2022 that may be closed by this pull request
ECS-Registry #3
Closed
3 tasks
Cavonstavant
Cavonstavant approved these changes Oct 2, 2022
View reviewed changes
Copy link
Contributor

@Cavonstavant Cavonstavant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

GuyomT
GuyomT approved these changes Oct 2, 2022
View reviewed changes
Copy link
Contributor

@GuyomT GuyomT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NTR

EmileEttel
EmileEttel approved these changes Oct 3, 2022
View reviewed changes
Copy link
Contributor

@EmileEttel EmileEttel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@aurelenc aurelenc merged commit 013b7c5 into main Oct 3, 2022
@Bootoyka Bootoyka deleted the 2-ecs-sparsearrayclass branch October 3, 2022 13:11
This was linked to issues Oct 12, 2022
Server - Part 1 - Timer/Frame per frame #25
Closed
Server - Part 1 - Timer basics #27
Open
@Cavonstavant Cavonstavant removed a link to an issue Oct 12, 2022
Server - Part 1 - Timer basics #27
Open
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EmileEttel EmileEttel EmileEttel approved these changes

@GuyomT GuyomT GuyomT approved these changes

@Cavonstavant Cavonstavant Cavonstavant approved these changes

Assignees

@aurelenc aurelenc

@Bootoyka Bootoyka

Labels
ECS
Projects
None yet
Milestone
Follow-up - Architecture validation
Development

Successfully merging this pull request may close these issues.

Server - Part 1 - Timer/Frame per frame ECS-Registry ECS-SparseArrayClass
5 participants
@Bootoyka @Cavonstavant @GuyomT @EmileEttel @aurelenc