Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Fix Did Dht Test Vector when 404 / 429 bug is resolved #286

Open
nitro-neal opened this issue Aug 15, 2024 · 0 comments
Open

[Bug] Fix Did Dht Test Vector when 404 / 429 bug is resolved #286

nitro-neal opened this issue Aug 15, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@nitro-neal
Copy link
Contributor

nitro-neal commented Aug 15, 2024

// as a replay protection attack if the same did is getting a 404 it will start returning a 429,
            // to get around this we just create a new did that is not published to get a 404 for this error code
            if(vector_output.did_resolution_metadata.error == "notFound") {
                // TODO: According to the did dht spec a 404 should be reutrned when trying to resolve a did that
                // does not exists. Currently it reutrns a 429. Uncomment this when resolved - https://github.com/TBD54566975/web5-rs/issues/286
                continue

                // let private_jwk = Ed25519Generator::generate();
                // let identity_key = ed25519::to_public_jwk(&private_jwk);
                // let did_dht =
                //     DidDht::from_identity_key(identity_key.clone()).expect("Should create did:dht");
                //
                // vector_input = VectorInput{
                //     did_uri: did_dht.did.uri,
                // };
            }
@nitro-neal nitro-neal added the bug Something isn't working label Aug 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: No status
Development

No branches or pull requests

1 participant