Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow object in service endpoint #990

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jakubkoci
Copy link

@jakubkoci jakubkoci commented Nov 5, 2024

According to did-core spec "The value of the serviceEndpoint property MUST be a string, a map, or a set composed of one or more strings and/or maps." This allows to use did dht with DIDComm protocol.

It still doesn't not handle "a set composed of more maps". I'm happy to add that to, but I wasn't sure about the approach. I see that txt data has this from:

id=dwn;t=DecentralizedWebNode;se=https://example.com/dwn,https://example.com/dwn2

but it felt a bit weird to add the stringified object to that

id=dwn;t=DecentralizedWebNode;se='{"uri":"https://example.com/dwn","routingKeys":["did:example:somemediator#somekey"]}'

so I encoded the object as base64Url:

id=dwn;t=DecentralizedWebNode;se=eyJ1cmkiOiJodHRwczovL2V4YW1wbGUuY29tL2R3biIsInJvdXRpbmdLZXlzIjpbImRpZDpleGFtcGxlOnNvbWVtZWRpYXRvciNzb21la2V5Il19

Now, I don't know if the goal isn't to make the whole thing human readable, in that case it's not a good solution. On the other hand, if it's fine to use encoded values, it's a question if to encode the string also in the case it's a string or array of string separated by commas.

Happy to hear any thoughts or feedback on this.

According to did-core spec "The value of the serviceEndpoint property
MUST be a string, a map, or a set composed of one or more strings and/or
maps." This allows to use did dht with DIDComm protocol.
Copy link

changeset-bot bot commented Nov 5, 2024

⚠️ No Changeset found

Latest commit: 28efeea

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant