Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve speed of console e2e test #3286

Closed
alecthomas opened this issue Oct 31, 2024 · 1 comment · Fixed by #3319
Closed

Improve speed of console e2e test #3286

alecthomas opened this issue Oct 31, 2024 · 1 comment · Fixed by #3319
Assignees
Labels
codebase-health Codebase health console Web console

Comments

@alecthomas
Copy link
Collaborator

The console e2e test is now one of the slowest tests, taking almost 5m, mostly due to the downloading of Chrome. Let's fix this, or alternatively move the test to the release so it only runs at release time.

Some ideas:

  • Create an image with Chrome pre-installed and specify that explicitly in the action.
  • Move the task to release time.
@alecthomas alecthomas added the console Web console label Oct 31, 2024
@alecthomas alecthomas added the codebase-health Codebase health label Oct 31, 2024
@ftl-robot ftl-robot mentioned this issue Oct 31, 2024
wesbillman added a commit that referenced this issue Nov 4, 2024
Cache playwright browser binaries to improve CI test speed

Fixes #3286
@wesbillman
Copy link
Member

wesbillman commented Nov 4, 2024

This might not be fully fixed, but the chrome part is cached now. It seems like most of the time is spent in the ftl dev --recreate and running tests. I'll keep looking into ways to speed up the tests as well.

~10s to download postgres
~30s to deploy modules
~60s to run tests

https://github.com/TBD54566975/ftl/actions/runs/11670102960/job/32493574418?pr=3321

Mon, 04 Nov 2024 18:12:41 GMT
[WebServer] info: Starting FTL with 1 controller(s)
Mon, 04 Nov 2024 18:12:42 GMT
[WebServer] info: {"status":"Pulling from library/postgres","id":"15.8"}
Mon, 04 Nov 2024 18:12:42 GMT
[WebServer] info: {"status":"Pulling fs layer","progressDetail":

... Then the controller starts

Mon, 04 Nov 2024 18:12:51 GMT
[WebServer] info: Controller started in 1.003928724s

... Then all modules are deployed.

Mon, 04 Nov 2024 18:13:23 GMT
[WebServer] info: All modules deployed in 39.98s, watching for changes...

.. Then all tests are complete

Mon, 04 Nov 2024 18:14:28 GMT
  41 passed (2.1m)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
codebase-health Codebase health console Web console
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants