Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cron methods called multiple times for long running deployments #3109

Closed
stuartwdouglas opened this issue Oct 14, 2024 · 1 comment · Fixed by #3122
Closed

Cron methods called multiple times for long running deployments #3109

stuartwdouglas opened this issue Oct 14, 2024 · 1 comment · Fixed by #3122
Assignees
@stuartwdouglas
Labels
P0 Work on this now

Comments

@stuartwdouglas
Copy link
Collaborator

It appears old cron methods are not being deactivated correctly, so on redeploy we end up with multiple calls.
@github-actions github-actions bot added the triage Issue needs triaging label Oct 14, 2024
@ftl-robot ftl-robot mentioned this issue Oct 14, 2024
Open
@stuartwdouglas
Copy link
Collaborator Author

I think this logic got lost in a refactor: 8ce9faf#diff-6ed83c343e05fdb52758a0311ad55be3fc913102be58e0f62722269a465950a6L369

@alec-brooks alec-brooks added P0 Work on this now and removed triage Issue needs triaging labels Oct 14, 2024
stuartwdouglas added a commit that referenced this issue Oct 15, 2024
@stuartwdouglas
fix: remove cron jobs on deactivation
48ed49c 
fixes #3109
@stuartwdouglas stuartwdouglas mentioned this issue Oct 15, 2024
Merged
stuartwdouglas added a commit that referenced this issue Oct 15, 2024
@stuartwdouglas
fix: remove cron jobs on deactivation
b2a5d89 
fixes #3109
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@stuartwdouglas stuartwdouglas

Labels
P0 Work on this now
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: remove cron jobs on deactivation TBD54566975/ftl
2 participants
@stuartwdouglas @alec-brooks