Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not all output reaching terminal before exit #3031

Closed
matt2e opened this issue Oct 8, 2024 · 0 comments · Fixed by #3032
Closed

Not all output reaching terminal before exit #3031

matt2e opened this issue Oct 8, 2024 · 0 comments · Fixed by #3032
Labels
triage Issue needs triaging

Comments

@matt2e
Copy link
Collaborator

matt2e commented Oct 8, 2024

Output from FTL is not always reaching the terminal. This seems to happen when larger text is printed right before exiting.
I think I'm seeing this when trying to get a schema diff, but instead of seeing the diff i expected, I get nothing or a partial result.

Steps to repro:

  • Add these lines to cmd_schema_diff.go.66:
fmt.Printf("=====\nbefore\n=====\n%v\n", current)
fmt.Printf("=====\nafter\n=====\n%v\n", other)
  • Start up FTL:ftl dev --recreate
  • In another terminal window, run ftl schema diff

Expected behaviour:

  • We would get a wall of text showing before and after schemas, followed by an empty diff

Actual behaviour:

  • The output stops before the first schema is printed, and the rest is lost.
@github-actions github-actions bot added the triage Issue needs triaging label Oct 8, 2024
@ftl-robot ftl-robot mentioned this issue Oct 8, 2024
stuartwdouglas added a commit that referenced this issue Oct 8, 2024
@matt2e matt2e closed this as completed in 80156ce Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
triage Issue needs triaging
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant