Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure Docker builds are tested in CI #2537

Closed
alecthomas opened this issue Aug 29, 2024 · 1 comment
Closed

Ensure Docker builds are tested in CI #2537

alecthomas opened this issue Aug 29, 2024 · 1 comment
Assignees
Labels
codebase-health Codebase health

Comments

@alecthomas
Copy link
Collaborator

It's currently easy for them to bitrot because we only run them when we cut a new release. We should add them to the main CI flow without releasing them, just to make sure they continue to work. Same with VSCode extension release, though I'm not too sure how to test that.

@alecthomas alecthomas added the codebase-health Codebase health label Aug 29, 2024
@github-actions github-actions bot added the triage Issue needs triaging label Aug 29, 2024
@ftl-robot ftl-robot mentioned this issue Aug 29, 2024
@alecthomas alecthomas self-assigned this Aug 29, 2024
@github-actions github-actions bot removed the triage Issue needs triaging label Aug 29, 2024
@alecthomas
Copy link
Collaborator Author

Fixed in #2562

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
codebase-health Codebase health
Projects
None yet
Development

No branches or pull requests

1 participant