Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better visibility on ingress errors #2517

Closed
gak opened this issue Aug 28, 2024 · 2 comments · Fixed by #2533
Closed

Better visibility on ingress errors #2517

gak opened this issue Aug 28, 2024 · 2 comments · Fixed by #2533
Assignees

Comments

@gak
Copy link
Contributor

gak commented Aug 28, 2024

logger.Debugf("bad request: %s", err.Error()) in ingress handler does not mention the verb involved and is difficult to know which request has failed in production.

This is related to a webhook coming in and erroring, but the user can not observe exactly why/how it failed. This is also very handy when you have little feedback from a webhook provider.

@github-actions github-actions bot added the triage Issue needs triaging label Aug 28, 2024
@ftl-robot ftl-robot mentioned this issue Aug 28, 2024
@jiyoonie9
Copy link

example error message:
bad request: 0:0: expected array, got string

@bradleydwyer bradleydwyer added next Work that will be be picked up next and removed triage Issue needs triaging labels Aug 28, 2024
@alecthomas
Copy link
Collaborator

We should replace:

	logger.Debugf("%s %s", r.Method, r.URL.Path)

with something like the following, so that all log messages have this context:

	logger = logger.Scope(fmt.Sprintf("%s %s", r.Method, r.URL.Path))

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants